Closed Bug 1469155 Opened Last year Closed 7 months ago
|Range::operator bool()| is non-functional because Ranged
Ptr's can't be compared against nullptr
47 bytes, text/x-phabricator-request
|Details | Review|
|Range::operator bool()| compares the RangedPtr member against |nullptr| , but RangedPtr doesn't have an applicable |operator==()| overload for comparisons against null pointers, so when |Range::operator bool()| is actually called and gets compiled, a compiler error is emitted.  https://searchfox.org/mozilla-central/rev/6eea08365e7386a2b81c044e7cc8a3daa51d8754/mfbt/Range.h#67  https://searchfox.org/mozilla-central/rev/6eea08365e7386a2b81c044e7cc8a3daa51d8754/mfbt/RangedPtr.h#235-256
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/704809991618 Add overloading for std::nullptr_t for RangedPtr equality operator r=froydnj
You need to log in before you can comment on or make changes to this bug.