1469228 - Upgrade rust libraries to not use syn-0.12

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

As a result of servo/webrender#2819, mozilla-central is going to start dragging in syn 0.14. Right now third_party/rust has syn 0.13 and syn 0.12. We should upgrade stuff such that we can drop syn 0.12, so that we don't end up with three copies of syn in the tree.

Comment 1

[Simon Sapin (:SimonSapin)]

`cargo update -p cstr-macros` removes one dependency.

The rest should be taken care of by upgrading malloc_size_of_derive and style_derive from https://github.com/servo/servo/, they have been upgraded to syn 0.13 there. I think Emilio has a script for cherry-picking across repos.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Yup, happy to take this.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1ffb899a5f02
Cherry-pick malloc_size_of_derive and style_derive changes from servo/servo#20690. r=me
https://hg.mozilla.org/integration/mozilla-inbound/rev/5ea92f9e5043
Update cstr-macros to v0.1.3. r=me
https://hg.mozilla.org/integration/mozilla-inbound/rev/f3a4d5ac04be
Revendor rust dependencies. r=me

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Thanks!

Comment 5

[Simon Sapin (:SimonSapin)]

https://github.com/servo/servo/issues/21059 tracks moving Servo and its dependencies to 0.14 (removing 0.13). The dependency graphs is different from Gecko’s, but has significant overlap.

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/1ffb899a5f02
https://hg.mozilla.org/mozilla-central/rev/5ea92f9e5043
https://hg.mozilla.org/mozilla-central/rev/f3a4d5ac04be