Closed Bug 1469265 Opened 8 years ago Closed 8 years ago

[wpt-sync] Sync PR 11547 - Do not override kReattach for ::first-letter.

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 11547 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/web-platform-tests/wpt/pull/11547 Details from upstream follow. Rune Lillesveen <futhark@chromium.org> wrote: > Do not override kReattach for ::first-letter. > > We incorrectly did an override with kForce for ::first-letter recalc > when we were already recalculating style for re-attachment (kReattach). > This caused crashes in FirstLetterPseudoElement::DidRecalcStyle. > > Bug: 853621, 853476, 853471, 853433, 853411 > Change-Id: Id34e6bdbaaeb3b4933a3e963b68f0bffcda0e40e > Reviewed-on: https://chromium-review.googlesource.com/1104176 > WPT-Export-Revision: bea71b0854929bc0741ddd092af29f9b2df2ff13
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/4465412a5b1b [wpt PR 11547] - Do not override kReattach for ::first-letter., a=testonly
https://hg.mozilla.org/mozilla-central/rev/4465412a5b1b
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.