Closed
Bug 1469305
Opened 6 years ago
Closed 6 years ago
avoid useless copies for GC statistics notifications
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla62
Tracking | Status | |
---|---|---|
firefox62 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file)
1.99 KB,
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
std::move'ing the string here enables us to avoid a useless copy of the string. Normally this would be just a refcounting increment/decrement, but since we've Adopt'd the string a couple of lines earlier and the incoming string is therefore just an owned character buffer, rather than a refcounted character buffer, the copy here is a "real" copy. What would be ideal here is to pass the (un-JSON'd) GCDescription out to the notification, so we don't even have to render and parse JSON, but that can be left for a later day.
Assignee | ||
Comment 1•6 years ago
|
||
Attachment #8985937 -
Flags: review?(continuation)
Updated•6 years ago
|
Attachment #8985937 -
Flags: review?(continuation) → review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c929d5b91314 avoid useless copies for GC statistics notifications; r=mccr8
Comment 3•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c929d5b91314
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•