Closed Bug 1469305 Opened 6 years ago Closed 6 years ago

avoid useless copies for GC statistics notifications

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

Details

Attachments

(1 file)

std::move'ing the string here enables us to avoid a useless copy of the
string.  Normally this would be just a refcounting increment/decrement,
but since we've Adopt'd the string a couple of lines earlier and the
incoming string is therefore just an owned character buffer, rather than
a refcounted character buffer, the copy here is a "real" copy.

What would be ideal here is to pass the (un-JSON'd) GCDescription out to
the notification, so we don't even have to render and parse JSON, but
that can be left for a later day.
Attachment #8985937 - Flags: review?(continuation) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c929d5b91314
avoid useless copies for GC statistics notifications; r=mccr8
https://hg.mozilla.org/mozilla-central/rev/c929d5b91314
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: