Update feed daemon to only manage subscribers on a revision if the bug is private, otherwise leave it alone

RESOLVED FIXED

Status

()

RESOLVED FIXED
5 months ago
5 months ago

People

(Reporter: dkl, Assigned: dkl)

Tracking

({conduit-triaged})

Production
conduit-triaged

Details

Attachments

(1 attachment)

(Assignee)

Description

5 months ago
Currently we only show a warning at the top of the revision when the revision is private and it states that you must use Bugzilla to manage the subscribers list. This is also true for public revisions that have bug ids attached and so we need to show some sort of warning anytime a bug id is attached.
(In reply to David Lawrence [:dkl] from comment #0)
> Currently we only show a warning at the top of the revision when the
> revision is private and it states that you must use Bugzilla to manage the
> subscribers list. This is also true for public revisions that have bug ids
> attached and so we need to show some sort of warning anytime a bug id is
> attached.

I was under the impression we would not manage the subscribers of public bugs? :mcote have you changed your mind on this?
Flags: needinfo?(mcote)

Comment 2

5 months ago
I hadn't; I think this was just a misunderstanding of requirements.  Admittedly I don't particularly like that we treat the subscribers list differently in the two situations.  However, going to the bug to add CCs for public patches seems to be even worse UX than the inconsistent behaviour.

We should revert this, at least for now.   dkl, agreed?
Flags: needinfo?(mcote) → needinfo?(dkl)
We should also factor in Bug 1467696 which this causes.
See Also: → bug 1467696
(Assignee)

Comment 4

5 months ago
(In reply to Mark Côté [:mcote] from comment #2)
> I hadn't; I think this was just a misunderstanding of requirements. 
> Admittedly I don't particularly like that we treat the subscribers list
> differently in the two situations.  However, going to the bug to add CCs for
> public patches seems to be even worse UX than the inconsistent behaviour.
> 
> We should revert this, at least for now.   dkl, agreed?

Sure thing. Shouldn't be that difficult. Only sync cc's when bug is private and not when public. Nothing to be done on the Phab side as the behavior already matches the desired outcome.

dkl
Assignee: nobody → dkl
Status: NEW → ASSIGNED
Flags: needinfo?(dkl)
(Assignee)

Updated

5 months ago
Summary: Post note at top of revision when linked to bug id that subscribers are synced with bugs cc list only → Update feed daemon to only manage subscribers on a revision if the bug is private, otherwise leave it alone
Keywords: conduit-triaged
(Assignee)

Comment 5

5 months ago
Created attachment 8987968 [details] [review]
github pr #627
Component: Phabricator → Extensions: PhabBugz
Product: Conduit → bugzilla.mozilla.org
Version: unspecified → Production
(Assignee)

Comment 6

5 months ago
Merged to master.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.