1469420 - release assert if nsTArray is destroyed while being iterated over

Status: NEW

(Core :: XPCOM, enhancement)

Description

[Andrew McCreight [:mccr8]]

Jed tweeted about bug 1321066 today, which got me to wondering if we could detect if an array is destroyed while we're iterating over it. This would work by adding a bit to the header that we'd set while we're iterating (I guess using AutoRestore or something if the iteration is nested), and then crashing in the array dtor if the bit is set. The case of an array being resized is already handled safely thanks to bounds checking, so we could only do this iteration check in the dtor to reduce overhead (and make the patch easier...).