Closed Bug 1469436 Opened 2 years ago Closed 2 years ago

Create a multi_dep loader and assign a first consumer

Categories

(Firefox Build System :: Task Configuration, task)

3 Branch
task
Not set

Tracking

(firefox-esr60 fixed, firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox-esr60 --- fixed
firefox63 --- fixed

People

(Reporter: Callek, Assigned: Callek)

Details

Attachments

(2 files, 1 obsolete file)

The main mental model of doing this for me is for beetmover, where I think it will be most useful in terms of potential cleanup.

The idea is that it takes all kind deps and yields to the taskgraph a dict of {kind: task, ...} for things that match the search function.

I'm not completely sold on my own implementation yet, so there are conceptual solutions that veer a slightly different route by all means mention them.
This is needed to not have a circular kind dependency when we actually spell out all dependencies (in a following patch)
Comment on attachment 8986067 [details]
Bug 1469436 - Create a multi_dep loader and assign a first consumer in l10n. r=tomprince r=aki

Aki Sasaki [:aki] has approved the revision.

https://phabricator.services.mozilla.com/D1696
Attachment #8986067 - Flags: review+
Comment on attachment 8986066 [details]
Bug 1469436 - Make repackage-signing distinct from its l10n, so we can depend on it in l10n for windows. r=tomprince

Tom Prince [:tomprince] has approved the revision.

https://phabricator.services.mozilla.com/D1695
Attachment #8986066 - Flags: review+
Comment on attachment 8986067 [details]
Bug 1469436 - Create a multi_dep loader and assign a first consumer in l10n. r=tomprince r=aki

Tom Prince [:tomprince] has approved the revision.

https://phabricator.services.mozilla.com/D1696
Attachment #8986067 - Flags: review+
Pushed by Callek@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2477607822a3
Make repackage-signing distinct from its l10n, so we can depend on it in l10n for windows. r=tomprince
https://hg.mozilla.org/integration/mozilla-inbound/rev/33f3e7a6ca7a
Create a multi_dep loader and assign a first consumer in l10n. r=tomprince r=aki
https://hg.mozilla.org/mozilla-central/rev/2477607822a3
https://hg.mozilla.org/mozilla-central/rev/33f3e7a6ca7a
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/59bf9ca50156
Port bug 1469436 (two changesets: 2477607822a3 and 33f3e7a6ca7a). rs=bustage-fix
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/d5a7d8ff24dd
Port bug 1469436, take 2 (port more of changeset 33f3e7a6ca7a). rs=bustage-fix
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/724fecd6bf88
Port bug 1469436, take 3 (port more of changeset 33f3e7a6ca7a). rs=bustage-fix DONTBUILD
Attachment #8988226 - Attachment is obsolete: true
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.