1469444 - Add MOZ_INIT_OUTSIDE_CTOR to ArraySpeciesLookup fields that are so initialized

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Comment 1

[Jeff Walden [:Waldo]]

Attachment: Patch

This is slightly more rigorous about exactly what state-fields are valid/checked at any given moment, and it gives some validity-detecting poisoning to boot.

Comment 2

[André Bargull [:anba]]

Comment on attachment 8986074 [details] [diff] [review]
Patch

Review of attachment 8986074 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/builtin/Array.h
@@ +271,5 @@
>      bool isArrayStateStillSane();
>  
>    public:
> +    /** Construct an |ArraySpeciesLookup| in the uninitialized state. */
> +    ArraySpeciesLookup() = default;

Not sure if it matters, but the "validity-detecting poisoning" won't apply for newly created ArraySpeciesLookup instances if |reset()| isn't called here anymore. :-)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6ce73daf92dc
Add MOZ_INIT_OUTSIDE_CTOR to ArraySpeciesLookup fields that are so initialized.  r=anba

Comment 4

[Jeff Walden [:Waldo]]

Oh, whoops -- I did want validity-detecting poison to be applied to ArraySpeciesLookup by default.  Readded the |purge();| to the body there and landed.

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/6ce73daf92dc