1469450 - release-update-verify-config tasks failing for 61.0rc

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Updates, defect, P1)

Description

[Jordan Lund (:jlund)]

example taskid:
NvDsOfpFSuOR2fy4Ggfw1w

log:
[task 2018-06-18T23:04:22.973Z] 23:04:22    FATAL - KeyError: 'last_watershed'

irc:
nthomas> suspect we drop it because last-watershed: null on the job, and https://dxr.mozilla.org/mozilla-beta/source/taskcluster/taskgraph/transforms/update_verify_config.py#94
nthomas> fyi, it's the releasetest config
16:22:44 er, release-localtest
16:23:00 the beta-localtest one is fine (UVCS on TH)
16:23:43 yes to your people question
16:25:11 this could be bustage from my https://bugzilla.mozilla.org/show_bug.cgi?id=1462120
<•nthomas> *waves hands* something to do with two levels of by-<foo> only for mozilla-release at https://hg.mozilla.org/releases/mozilla-release/file/6f3df7ea04aa672f91f3f80cf52eb67114b0c2fe/taskcluster/ci/release-update-verify-config/kind.yml#l75 and
16:55:06 https://hg.mozilla.org/releases/mozilla-release/file/6f3df7ea04aa672f91f3f80cf52eb67114b0c2fe/taskcluster/taskgraph/transforms/update_verify_config.py#l88

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

This comes from https://hg.mozilla.org/releases/mozilla-release/rev/39eed777c0c4#l9.11. We need to use a regexp in the key so that it matches.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: Bug 1469450 - release-update-verify-config tasks failing for 61.0rc,

The by-project and by-build-platform are collapsed by resolve_keyed_by(), and in turn by keymatch() in
utils/attributes.py. That needs a regexp to look for matches (if a simple match isn't possible). Rev
39eed777c0c4 missed that when it landed. The trailing hypens are to distringuish between the two linux
platforms.

Review commit: https://reviewboard.mozilla.org/r/251524/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/251524/

Comment 3

[Aki Sasaki (not active)]

Comment on attachment 8986077 [details]
Bug 1469450 - release-update-verify-config tasks failing for 61.0rc,

https://reviewboard.mozilla.org/r/251524/#review257796

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/46934e51b3e2
release-update-verify-config tasks failing for 61.0rc, r=aki

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

Beta: RyanVM will merge to in the next day or so
Release: https://hg.mozilla.org/releases/mozilla-release/rev/64f1fee0f16ca0c37c5c2a5f11be4461f2b37bc5

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

https://tools.taskcluster.net/groups/HolVnqBSST-lzsRazKn_Ow is a separate graph with corrected update-verify-config jobs, and downstream update-verify. All the jobs are green on that, so I'm confident that a 61.0 build2 will be fine.

Looks like the patch will also work fine with the changes in 62.0 from https://hg.mozilla.org/mozilla-central/rev/d2202116d877 (bug 1464523).

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/46934e51b3e2

Comment 8

[Nick Thomas [:nthomas] (UTC+12)]

> Beta: RyanVM will merge to in the next day or so

FTR - https://hg.mozilla.org/releases/mozilla-beta/rev/46934e51b3e2