1469487 - [wpt-sync] Sync PR 11560 - Reland: Floats and out-of-flow objects may not be adjacent to anonymous blocks.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 11560 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/11560
Details from upstream follow.

Morten Stenshorne <[e-mail]> wrote:
>  Reland: Floats and out-of-flow objects may not be adjacent to anonymous blocks.
>  
>  Floats and out-of-flow objects need to be true layout siblings of the
>  inlines, or rendering will be wrong. This means that such objects should
>  never be siblings of anonymous blocks, but rather inside them. This
>  already works correctly for initial layout tree building, and also for
>  many DOM manipulations. However, code was missing to satisfy this
>  requirement if we removed a regular block that was a sibling of an
>  anonymous block and either a float or out-of-flow positioned object.
>  
>  This even caused a crash triggered by ruby code, which ended up mixing
>  inline and block children within the same container. That is not
>  allowed. This happened in the MoveAllChildrenIncludingFloatsTo() call
>  inside LayoutRubyBase::MoveBlockChildren(). Added a DCHECK to
>  MoveAllChildrenIncludingFloatsTo() (which could fail prior to this fix);
>  When moving children from one container to another, either both or none
>  of the containers must have inline children.
>  
>  This is a reland of https://chromium-review.googlesource.com/1102690
>  with some modifications to avoid bug 853552.
>  
>  Bug: 852640
>  Change-Id: I0f8a0aa5523e8fe60c841164d25aad088f4b728f
>  
>  Reviewed-on: https://chromium-review.googlesource.com/1104900
>  WPT-Export-Revision: b891dc03db1efa4b76bdd026dbf83c5a21853773

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=7c9bc2310abf29b4ebbc3ac8dcc0830f184a505a

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=f797a94aaabd29f56ce1cc47e9f0c48363bdbf56

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Ran 2 tests
PASS   : 2

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a15bfb3c770e
[wpt PR 11560] - Reland: Floats and out-of-flow objects may not be adjacent to anonymous blocks., a=testonly

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/a15bfb3c770e