Closed Bug 1469518 Opened Last year Closed Last year

Clearing history for "today" fails to clear entries within the first second after midnight

Categories

(Toolkit :: Places, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: jfkthame, Assigned: jfkthame)

References

Details

(Whiteboard: [fxsearch])

Attachments

(1 file)

When the test fix in bug 1469104 was pushed to try, I found that it caused a different test failure to appear: it fails on "Pretend visit to today.com should now be deleted".

Looking into the code, this turns out to be a real bug:

https://searchfox.org/mozilla-central/rev/f822a0b61631cbb38901569e69b4967176314aa8/browser/modules/Sanitizer.jsm#204-210

The start of the timespan for "today" is set back to midnight by forcing the hours, minutes, and seconds to zero; but it fails to reset milliseconds, with the result that any entries that have timestamps from 00:00:00.000 to 00:00:00.999 do not get sanitized.
Comment on attachment 8986129 [details] [diff] [review]
Ensure history sanitization for "today" reaches all the way back to exactly midnight

Review of attachment 8986129 [details] [diff] [review]:
-----------------------------------------------------------------

thanks, this is great!
Attachment #8986129 - Flags: review?(mak77) → review+
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: [fxsearch]
Pushed by jkew@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8644e415f6ba
Ensure history sanitization for "today" reaches all the way back to exactly midnight. r=mak
https://hg.mozilla.org/mozilla-central/rev/8644e415f6ba
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.