Closed
Bug 1469590
Opened 7 years ago
Closed 7 years ago
XCUITest: Fix TopTabTest - testSwitchBetweenTabsNoPrivatePrivateToastButton
Categories
(Firefox for iOS :: Build & Test, enhancement)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fxios | 12.0 | --- |
People
(Reporter: isabel_rios, Assigned: isabel_rios)
Details
Attachments
(1 file)
This test is failing because it does not find the element on the website.
The test is only active for iPhone because the toast option is not implemented on iPad, that's why the failure is only seen on that schema.
Looking for a different element/website that does not look like it is going to change in the near future
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8986388 -
Flags: review?(npark)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8986388 [details] [review]
Pull Request
so does this pr also disable tests on ipad, or was it already turned off on ipad before?
Attachment #8986388 -
Flags: review?(npark) → review+
|
|
Assignee | |
Comment 3•7 years ago
|
||
That was disabled before, the comment was there, my comment in the bug was just to clarify why we were not seing the issue on BB for iPad, just in case you checked the logs
|
|
Assignee | |
Comment 4•7 years ago
|
||
Landed on master: https://github.com/mozilla-mobile/firefox-ios/commit/996922b85164345bb44aab60413cfc4793743845
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [needsuplift]
|
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → irios.mozilla
|
|
Assignee | |
Comment 5•7 years ago
|
||
Uplifted to v12.x: https://github.com/mozilla-mobile/firefox-ios/commit/e23da5b9a44448f518b3a53b8a042c2e6e1742c0
Whiteboard: [needsuplift]
You need to log in
before you can comment on or make changes to this bug.
Description
•