Closed Bug 1469617 Opened 6 years ago Closed 6 years ago

Upgrade docker-worker to use rootUrl

Categories

(Taskcluster :: Services, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bstack, Assigned: dustin)

References

Details

No description provided.
No longer depends on: 1469614
No longer blocks: 1459075
Depends on: 1459075
I can work on this.
Assignee: nobody → dustin
I think what's necessary here is to take a rootUrl configuration when starting the worker and use that to configure clients for internal use. Bug 1460015 covers what is provided to tasks, so I won't try to change that here.
And like all of the other services, this is going to involve some massive library updates..
Depends on: 1446977
Note, the provisioner creates userdata json here: https://github.com/taskcluster/aws-provisioner/blob/a42be08d28d1eec357c7badb959f41bb57aadc88/lib/worker-type.js#L607-L621 Maybe this could be patched to add root url (in addition to provisionerBaseUrl which would be nice to keep for backwards compatibility).
(In reply to Pete Moore [:pmoore][:pete] from comment #5) > Note, the provisioner creates userdata json here: > https://github.com/taskcluster/aws-provisioner/blob/ > a42be08d28d1eec357c7badb959f41bb57aadc88/lib/worker-type.js#L607-L621 > > Maybe this could be patched to add root url (in addition to > provisionerBaseUrl which would be nice to keep for backwards compatibility). For simplicity, maybe this could be hardcoded to 'https://taskcluster.net' if that doesn't break any staging environments, and we don't intend aws-provisioner to work with redeployable workers?
Needs a rebase.
See Also: → 1462768
I'll implement comment 5 in bug 1462768. (In reply to Dustin J. Mitchell [:dustin] pronoun: he from comment #7) > Needs a rebase. The docker-worker PR?
Yeah, it was a reminder-to-self. I have rebased and I'm still working on getting the tests to pass.
Commits pushed to master at https://github.com/taskcluster/docker-worker https://github.com/taskcluster/docker-worker/commit/0d8f743a84161a668af20c4e754c320ae5dea2e2 Bug 1469617 - remove upload-schema This hasn't been used since Feb 2017, and schemas will eventually be registered with the worker manager. https://github.com/taskcluster/docker-worker/commit/adbca98c86d591186c13c893366a01a6dd53941f Bug 1469617 - remove use of taskcluster-base This replaces it with the constituent libraries; newest versions of most except taskcluster-lib-validate which has changed dramatically since then. https://github.com/taskcluster/docker-worker/commit/1cd3a314227990c68544d7237bf9d70a37aa41ae Bug 1469617 - add rootUrl config https://github.com/taskcluster/docker-worker/commit/9737adc8e73dcb61503ad5de25034761747a26dc Bug 1469617 - upgrade taskcluster-lib-validate https://github.com/taskcluster/docker-worker/commit/4fbfe3051be784055b109aa627a987ac408d5533 Bug 1469617 - update tc-lib-monitor https://github.com/taskcluster/docker-worker/commit/220ebc8bdc8cc8ca28c5d7070ab554d26be56caf Bug 1469617 - remove unused taskcluster-azure-blobstream https://github.com/taskcluster/docker-worker/commit/a3817a170610c44b0facafb519977deecdbcb4d6 Bug 1469617 - upgrade taskcluster-client and get rootUrl from aws The new client requires rootUrl and does not accept baseUrl. We put rootUrl into the config/runtime, and then get it from there wherever it is needed. For tets, we assume that TASKCLUSTER_ROOT_URL is set (we already assume TASKCLUSTER_CLIENT_ID and TASKCLUSTER_ACCESS_TOKEN are set). The `hasPrefixedScopes` method needed some attention, since it didn't have access to runtime. It was also calling auth.expandScopes multiple times for each task; reducing that to just once should help the auth service run a little cooler, too. https://github.com/taskcluster/docker-worker/commit/45dac9eaf3fc16c4d693f02c5c1344c9b3816635 Bug 1469617 - use libUrls to generate tools links https://github.com/taskcluster/docker-worker/commit/29b4f323009d00b007f358b4cf201e04c340c080 Bug 1469617 - remove unused, nonfunctional script https://github.com/taskcluster/docker-worker/commit/8b6a7d0e06eb61b67aad7dac85b77cd4327b4b47 Bug 1469617 - use https://taskcluster.net rootUrl for all CI https://github.com/taskcluster/docker-worker/commit/a8a408f5cfe9b7ef06b1af31a520b4dd54ad3953 Bug 1469617 - clean up worker main to report errors https://github.com/taskcluster/docker-worker/commit/4f22aac1b79e5947c32953d181cdb9e560913d03 Bug 1469617 - pass rootUrl to child docker worker instance https://github.com/taskcluster/docker-worker/commit/d046dd59b3015f42d0d8deb6d04d475771357792 Bug 1469617 - include logs in assertion failure output https://github.com/taskcluster/docker-worker/commit/7463e56fd777c870ff9391de2f290c98ca767ff9 Bug 1469617 - add scopes without which tests should never have passed (!@#!%@) https://github.com/taskcluster/docker-worker/commit/bb26306bfc4fee54dcdc5b1414e2f88c18066dea Bug 1469617 - use correct scope for garbage caches https://github.com/taskcluster/docker-worker/commit/a930de7b6101f95caa1f91e986f40e27f3039abb Merge pull request #412 from djmitche/bug1469617 Bug 1469617 - upgrade to use rootUrl
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Component: Redeployability → Services
You need to log in before you can comment on or make changes to this bug.