1469679 - Blocklisted addons cause sync to create an error log: Failed to apply incoming record Error: Add-on not found after install

Status: NEW

(Firefox :: Sync, defect, P3)

Description

[Wellington Torrejais da Silva]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:62.0) Gecko/20100101 Firefox/62.0
Build ID: 20180619102337

Steps to reproduce:

After start with clean profile(Trying to solve problems...) I can't sync anything anymore...

I got a error with addon sync, "mini vid" extension, maybe experimental test pilot from the past.

But clean profile don't have addons installed.



Actual results:

Nothing syncing(whitout history, addons, password :-( sad...)

The error (Many times, linux terminal):
1529438638604	Sync.AddonUtils	INFO	Found 0 / 1 add-ons during repository search.
1529438638604	Sync.Engine.Addons.Store	WARN	Failed to apply incoming record {a13e95f2-1743-4f74-a4fb-cbb7dafbf94a}: Error: Add-on not found after install: @min-vid (resource://services-sync/engines/addons.js:335:13) JS Stack trace: [e-mail]:335:13
async*[e-mail]:350:13
async*[e-mail]:300:11
async*[e-mail]:315:15
async*[e-mail]:1415:29
async*[e-mail]:1296:33
async*[e-mail]:1837:13
async*[e-mail]:179:27
async*[e-mail]:900:12
async*[e-mail]:214:13
async*[e-mail]:156:21
async*[e-mail]:1131:13
async*[e-mail]:179:27
async*[e-mail]:135:22
async*[e-mail]:1124:12
async*sync/<@service.js:1116:13
async*[e-mail]:105:22
async*[e-mail]:1105:12
async*syncIfMPUnlocked/<@policies.js:541:7


Crash report not generated.. (Why not?)




Expected results:

No errors and sync working...
Trying to help with sync test...

Thanks!

Comment 1

[Gingerbread Man]

Please enter about:sync-log into the address bar and attach the latest log.

Comment 2

[Wellington Torrejais da Silva]

Attachment: sync-errors1.tar.gz

See my error examples

Comment 3

[Wellington Torrejais da Silva]

(In reply to Gingerbread Man from comment #1)
> Please enter about:sync-log into the address bar and attach the latest log.

Hi, 

I will attach examples of my error logs.

Thanks

Comment 4

[Wellington Torrejais da Silva]

Attachment: error-sync-1529501343082.txt

Comment 5

[Wellington Torrejais da Silva]

Attachment: error-sync-1530531098254.txt

Comment 6

[Wellington Torrejais da Silva]

Attachment: error-sync-1529523529791.txt.tar.bz2

Comment 7

[Wellington Torrejais da Silva]

Attachment: error-sync-1529940379354.txt.bz2

Comment 8

[Wellington Torrejais da Silva]

Attachment: error-sync-1530531098254.txt.bz2

Comment 9

[Wellington Torrejais da Silva]

Attachment: error-sync-1529501343082.txt.bz2

Comment 10

[Mark Hammond [:markh] [:mhammond]]

I'm afraid none of the logs you uploaded have the reported error "Error: Add-on not found after install: @min-vid"

Comment 11

[Wellington Torrejais da Silva]

(In reply to Mark Hammond [:markh] from comment #10)
> I'm afraid none of the logs you uploaded have the reported error "Error:
> Add-on not found after install: @min-vid"

Sorry, I got more examples.

From log:

1536007465584	Sync.Engine.Addons.Store	WARN	Failed to apply incoming record {dce71e0b-0432-4151-a5b2-ff0dcef99483}: Error: Add-on not found after install: [e-mail](resource://services-sync/engines/addons.js:341:13) JS Stack trace: [e-mail]:341:13
async*[e-mail]:376:13
async*[e-mail]:353:13
async*[e-mail]:306:11
async*[e-mail]:316:15
async*[e-mail]:1411:29
async*[e-mail]:1292:33
async*[e-mail]:1835:13
async*[e-mail]:179:27
async*[e-mail]:895:12
async*[e-mail]:214:13
async*[e-mail]:156:21
async*[e-mail]:1139:13
async*[e-mail]:179:27
async*[e-mail]:135:22
async*[e-mail]:1132:12
async*sync/<@service.js:1124:13
async*[e-mail]:105:22
async*[e-mail]:1113:12
async*syncIfMPUnlocked/<@policies.js:537:7


Can I help you in the search of origin?
Thanks

Comment 12

[Wellington Torrejais da Silva]

Attachment: error-sync-1536007467508.txt

Comment 13

[Wellington Torrejais da Silva]

Attachment: error-sync-1536013518287.txt

Comment 14

[Wellington Torrejais da Silva]

Attachment: error-sync-1536014153919.txt

Comment 15

[Mark Hammond [:markh] [:mhammond]]

I found https://www.web-security.com/how-to-install/, which offers a .xpi file and also points to https://addons.mozilla.org/de/firefox/addon/web-security/ to get it on addons.mozilla.org - however, that latter page shows an error.  addons.mozilla.org doesn't host an addon with this ID at all.

What is your history with this addon? Is it possible you installed it from addons.mozilla.org, but it was then taken down from addons.mozilla.org? I think that would explain the error you are seeing.

Comment 16

[Wellington Torrejais da Silva]

I remenber me installed this addon in the past.

I heard about mozilla team found addons for security with problems and remove in the running browsers.
Is that maybe related? Or I'm I've removed the addon from another client.

By the way sometimes I got errors related of that. Can the sync fix these type of problem by yourself? Because in this case I can't do anything. Can I?

(Learning English...)

Thanks!

Comment 17

[Wellington Torrejais da Silva]

How about the removal of the item from the origin after certain number of tries?

1535060765698	Sync.Engine.Addons.Store	WARN	Failed to apply incoming record {dce71e0b-0432-4151-a5b2-ff0dcef99483}: Error: Add-on not found after install: [e-mail](resource://services-sync/engines/addons.js:341:13) JS Stack trace: [e-mail]:341:13

Thanks!

Comment 18

[Wellington Torrejais da Silva]

Please see:

https://tecnoblog.net/256255/mozilla-complementos-firefox-usuarios/
https://www.bleepingcomputer.com/news/security/mozilla-removes-23-firefox-add-ons-that-snooped-on-users/

The Mozilla removed the addon and after this action my sync not work anymore.
I thinks sync fix for this case is recommended.

https://tecnoblog.net/wp-content/uploads/2018/08/WebSecurity-removed-700x255.png
https://www.bleepstatic.com/content/posts/2018/08/16/WebSecurity-removed.png

Comment 19

[Wellington Torrejais da Silva]

Hi,

Please see: https://bugzilla.mozilla.org/show_bug.cgi?id=1483995

Is the add-on sync problem  a consequence of the Bug 1483995?

Thanks

Comment 20

[Rob Wu [:robwu]]

Thanks for the report and sleuthing.

The error message "Add-on not found after install: [guid of blocklisted addon]" looks like an accurate description of the situation. Indeed, the add-on GUIDs from this bug are from add-ons that are blocklisted (https://wiki.mozilla.org/Blocklisting).

This (client) logic needs to be fixed to account for blocklisted add-ons (don't fail hard):
https://searchfox.org/mozilla-central/rev/a41fd8cb947266ea2e3f463fc6e31c88bfab9d41/services/sync/modules/engines/addons.js#313-341

If this bug report is true, then it means that many users who had installed a blocklisted add-on cannot sync. That sounds like a pretty bad bug, and if possible a backend fix would be nice (e.g. by serving an empty dummy add-on via sync).

Comment 21

[Mark Hammond [:markh] [:mhammond]]

Thanks for digging in!

Sync works fine, it just creates an error log as it fails to handle a single addon - all other addons and all other engines work fine. The only fix I think Sync should make here would be to not create an error log, but that's not a high priority as the user typically never sees any indication of this error.