1469688 - Allow reordering the precedence of installed language packs

Status: VERIFIED FIXED

(Firefox :: Settings UI, enhancement, P2)

Description

[Mark Striemer [:mstriemer]]

When a user has multiple language packs installed they might want to reorder which languages they would like to see. This UI can be quite similar to the webpage languages dialog.

There is a mock for a nicer UI for this, so try to re-use the webpage dialog in a way that they can both be updated later.

Comment 1

[Mark Striemer [:mstriemer]]

Attachment: Bug 1469688 - Part 1: Generalize language switching code in prefs r?jaws,zbraniecki

MozReview-Commit-ID: 8Ym7frVSLug

Comment 2

[Mark Striemer [:mstriemer]]

Attachment: Bug 1469688 - Part 2: Allow reordering of browser languages in prefs r?Gijs,zbraniecki,flod

Comment 3

[Mark Striemer [:mstriemer]]

Attachment: reorder-locales.mov.gif

Comment 4

[Francesco Lodolo [:flod]]

Comment on attachment 8999312 [details]
Bug 1469688 - Part 2: Allow reordering of browser languages in prefs r?Gijs,zbraniecki,flod

Francesco Lodolo [:flod] has approved the revision.

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8999311 [details]
Bug 1469688 - Part 1: Generalize language switching code in prefs r?jaws,zbraniecki

Zibi Braniecki [:gandalf][:zibi] has approved the revision.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8999311 [details]
Bug 1469688 - Part 1: Generalize language switching code in prefs r?jaws,zbraniecki

(away 8/20-8/27) Jared Wein [:jaws] (please needinfo? me) has approved the revision.

Comment 7

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8999312 [details]
Bug 1469688 - Part 2: Allow reordering of browser languages in prefs r?Gijs,zbraniecki,flod

Zibi Braniecki [:gandalf][:zibi] has approved the revision.

Comment 8

[Mark Striemer [:mstriemer]]

I've updated based on your comments, Gijs, and managed to remove some of the code. Thanks for the review!

Comment 9

[:Gijs (he/him)]

Comment on attachment 8999312 [details]
Bug 1469688 - Part 2: Allow reordering of browser languages in prefs r?Gijs,zbraniecki,flod

:Gijs (he/him) has approved the revision.

Comment 10

[Mark Striemer [:mstriemer]]

Attachment: Bug 1469688 - Part 3: Maintain the order of browser languages dialog r?Gijs

Comment 11

[Mark Striemer [:mstriemer]]

Attachment: Bug 1469688 - Part 4: Test the browser languages dialog r?Gijs

Comment 12

[:Gijs (he/him)]

Comment on attachment 9004696 [details]
Bug 1469688 - Part 3: Maintain the order of browser languages dialog r?Gijs

:Gijs (he/him) has approved the revision.

Comment 13

[:Gijs (he/him)]

Comment on attachment 9004697 [details]
Bug 1469688 - Part 4: Test the browser languages dialog r?Gijs

:Gijs (he/him) has approved the revision.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/505226ad06ab
Part 1: Generalize language switching code in prefs r=jaws,zbraniecki
https://hg.mozilla.org/integration/mozilla-inbound/rev/6edbb5f98d6e
Part 2: Allow reordering of browser languages in prefs r=Gijs,zbraniecki,flod
https://hg.mozilla.org/integration/mozilla-inbound/rev/bcec32bfccff
Part 3: Maintain the order of browser languages dialog r=Gijs
https://hg.mozilla.org/integration/mozilla-inbound/rev/55662a7bc29c
Part 4: Test the browser languages dialog r=Gijs

Comment 15

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/505226ad06ab
https://hg.mozilla.org/mozilla-central/rev/6edbb5f98d6e
https://hg.mozilla.org/mozilla-central/rev/bcec32bfccff
https://hg.mozilla.org/mozilla-central/rev/55662a7bc29c

Comment 16

[Cristian Baica [:cbaica], Release Desktop QA]

Could you please provide some steps to follow in order to confirm this?

I cannot find the drop-down in the language section, the only button available is to choose the web pages display language.
I have also tried to see if it activates by adding different language packs to the browser, but without success.

Comment 17

[Francesco Lodolo [:flod]]

@cristian
We have a PI request tracking the whole feature (Cristian Craciun is coordinating), not sure if we need to verify each bug?

The feature is behind the intl.multilingual.enabled flag.

Comment 18

[Rares Doghi, Desktop QA]

This Is Confirmed as fixed in Firefox 64.0, Nightly 66 and Beta 65.0b6.