1469697 - Use run-task "using" code for all run-task based tasks

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Gregory Szorc [:gps]]

Currently, a number of "using: X" tasks end up using run-task. e.g. "using: mozharness."

run-task based tasks make a number of assumptions and have added functionality.

We should probably have all run-task based tasks go through the same code for populating the task definition so things are consistent and we don't have to resort to hacks like https://hg.mozilla.org/mozilla-central/file/257c191e7903/taskcluster/taskgraph/transforms/task.py#l819.

Comment 1

[Mike Hommey [:glandium]]

FWIW, I'm doing this in bug 1525373 for the mozharness transforms, but won't touch the other transforms that use run-task.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1469697 - Use run-task transform for spidermonkey tasks.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1469697 - s/GECKO_DIR/GECKO_PATH/ for hazard build scripts.

Most other tasks use GECKO_PATH, as that's what run-task uses.

Comment 4

[Mike Hommey [:glandium]]

Attachment: Bug 1469697 - Use run-task transform for hazard tasks.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a1e9b4955743
Use run-task transform for spidermonkey tasks. r=tomprince
https://hg.mozilla.org/integration/mozilla-inbound/rev/993f7ea9b260
s/GECKO_DIR/GECKO_PATH/ for hazard build scripts. r=nalexander
https://hg.mozilla.org/integration/mozilla-inbound/rev/a90eaeb66077
Use run-task transform for hazard tasks. r=tomprince

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/a1e9b4955743
https://hg.mozilla.org/mozilla-central/rev/993f7ea9b260
https://hg.mozilla.org/mozilla-central/rev/a90eaeb66077