1469741 - Maybe implement scrollbar color and width properties when native theme is disabled

Status: RESOLVED FIXED

(Core :: Layout, enhancement, P3)

Description

[Xidorn Quan [:xidorn] UTC+11]

There is an effort to discard native theme implementation and rely on CSS to define how widgets should be rendered (see bug 1381938 for example).

Currently scrollbar color properties are implemented from native theme implementations directly, which would stop working if native theme is disabled.

If we are going to define scrollbar appearance via CSS, we would need to have a new mechanism to put value from content CSS to CSS value in internal CSS. Alternatively, if we can make progress on bug 645563 to make scrollbar a single element, this kind of mechanism may not be necessary as we would likely have all the rendering code in C++ with that.

It is not a high priority at the moment, though, as it seems we are still far from disabling native theme by default.

Comment 1

[Xidorn Quan [:xidorn] UTC+11]

I almost have a working prototype of this.

But I would hope we land bug 1475033 first so that I can also have scrollbar-width work directly.

Comment 2

[Xidorn Quan [:xidorn] UTC+11]

Attachment: Bug 1469741 part 1 - Apply scrollbar colors to background of some scrollbar parts when theme doesn't support them. r=mattwoodrow

Comment 3

[Xidorn Quan [:xidorn] UTC+11]

Attachment: Bug 1469741 part 2 - Ensure scrollbar has a width even when it's not supported by the theme. r=dholbert

Depends on D3578

Comment 4

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 9001839 [details]
Bug 1469741 part 1 - Apply scrollbar colors to background of some scrollbar parts when theme doesn't support them. r=mattwoodrow

Matt Woodrow (:mattwoodrow) has approved the revision.

Comment 5

[Daniel Holbert [:dholbert]]

Comment on attachment 9001840 [details]
Bug 1469741 part 2 - Ensure scrollbar has a width even when it's not supported by the theme. r=dholbert

Daniel Holbert [:dholbert] has approved the revision.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6fc06d9d7fc0
part 1 - Apply scrollbar colors to background of some scrollbar parts when theme doesn't support them. r=mattwoodrow

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bdbea15cf0ba
part 2 - Ensure scrollbar has a width even when it's not supported by the theme. r=dholbert

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/6fc06d9d7fc0
https://hg.mozilla.org/mozilla-central/rev/bdbea15cf0ba