1469759 - Get rid of mozISpellI18NManager and mozISpellI18NUtil

Status: RESOLVED FIXED

(Core :: Spelling checker, enhancement, P3)

Description

[Makoto Kato [:m_kato]]

mozISpellI18NManager and mozISpellI18NUtil are unused from script, so we should get rid of these interfaces.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1469759 - Part 1. Use mozEnglishWordUtils directly.

mozISpellI18NManager is only used to get mozISpellI18NUtil. And
mozISpellI18NUtil is only implemented on mozEnglishWordUtils.  So we should
create an instance of mozEnglishWordUtils instead of using mozISpellI18NManager.

Review commit: https://reviewboard.mozilla.org/r/255234/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/255234/

Comment 2

[Makoto Kato [:m_kato]]

Attachment: Bug 1469759 - Part 2. Get rid of mozISpellI18NManager.

No one uses mozISpellI18NManager, so we should get rid of this interface.

Review commit: https://reviewboard.mozilla.org/r/255236/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/255236/

Comment 3

[Makoto Kato [:m_kato]]

Attachment: Bug 1469759 - Part 3. Remove unused methods of mozISpellI18NUtil.

Some methods in mozISpellI18NUtil are unused now.

Review commit: https://reviewboard.mozilla.org/r/255238/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/255238/

Comment 4

[Makoto Kato [:m_kato]]

Attachment: Bug 1469759 - Part 4. Get rid of mozISpellI18NUtil.

mozEnglishWordUtils should be deXPCOM since it isn't used from script, then get
rid of mozISpellI18NUtil that is unused.

Review commit: https://reviewboard.mozilla.org/r/255240/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/255240/

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away: 9/21~9/29)]

Comment on attachment 8990207 [details]
Bug 1469759 - Part 1. Use mozEnglishWordUtils directly.

https://reviewboard.mozilla.org/r/255234/#review262132

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away: 9/21~9/29)]

Comment on attachment 8990208 [details]
Bug 1469759 - Part 2. Get rid of mozISpellI18NManager.

https://reviewboard.mozilla.org/r/255236/#review262136

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away: 9/21~9/29)]

Comment on attachment 8990209 [details]
Bug 1469759 - Part 3. Remove unused methods of mozISpellI18NUtil.

https://reviewboard.mozilla.org/r/255238/#review262138

::: commit-message-160ac:1
(Diff revision 1)
> +Bug 1469759 - Part 3. Remove unused method of mozISpellI18NUtil. r?masayuki

nit: s/method/methods

::: extensions/spellcheck/src/mozEnglishWordUtils.cpp:29
(Diff revision 1)
>  NS_IMPL_CYCLE_COLLECTION(mozEnglishWordUtils,
>                           mURLDetector)
>  
>  mozEnglishWordUtils::mozEnglishWordUtils()
>  {
> -  mLanguage.AssignLiteral("en");
> +  mURLDetector = do_CreateInstance(MOZ_TXTTOHTMLCONV_CONTRACTID);

Another approach is, to use initialization list. But up to you.

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away: 9/21~9/29)]

Comment on attachment 8990210 [details]
Bug 1469759 - Part 4. Get rid of mozISpellI18NUtil.

https://reviewboard.mozilla.org/r/255240/#review262140

Really nice. Thank you!

Comment 9

[Makoto Kato [:m_kato]]

Comment on attachment 8990209 [details]
Bug 1469759 - Part 3. Remove unused methods of mozISpellI18NUtil.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/255238/diff/1-2/

Comment 10

[Makoto Kato [:m_kato]]

Comment on attachment 8990210 [details]
Bug 1469759 - Part 4. Get rid of mozISpellI18NUtil.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/255240/diff/1-2/

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c40c74e6f347
Part 1. Use mozEnglishWordUtils directly. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/91eb438b6af0
Part 2. Get rid of mozISpellI18NManager. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/b68d9811ac08
Part 3. Remove unused methods of mozISpellI18NUtil. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/f1cce2949d23
Part 4. Get rid of mozISpellI18NUtil. r=masayuki

Comment 12

[Raul Gurzau (:RaulGurzau)]

https://hg.mozilla.org/mozilla-central/rev/c40c74e6f347
https://hg.mozilla.org/mozilla-central/rev/91eb438b6af0
https://hg.mozilla.org/mozilla-central/rev/b68d9811ac08
https://hg.mozilla.org/mozilla-central/rev/f1cce2949d23