Closed
Bug 1469759
Opened 3 years ago
Closed 3 years ago
Get rid of mozISpellI18NManager and mozISpellI18NUtil
Categories
(Core :: Spelling checker, enhancement, P3)
Core
Spelling checker
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: m_kato, Assigned: m_kato)
Details
Attachments
(4 files)
mozISpellI18NManager and mozISpellI18NUtil are unused from script, so we should get rid of these interfaces.
Updated•3 years ago
|
Priority: -- → P3
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 5•3 years ago
|
||
mozreview-review |
Comment on attachment 8990207 [details] Bug 1469759 - Part 1. Use mozEnglishWordUtils directly. https://reviewboard.mozilla.org/r/255234/#review262132
Attachment #8990207 -
Flags: review?(masayuki) → review+
Comment 6•3 years ago
|
||
mozreview-review |
Comment on attachment 8990208 [details] Bug 1469759 - Part 2. Get rid of mozISpellI18NManager. https://reviewboard.mozilla.org/r/255236/#review262136
Attachment #8990208 -
Flags: review?(masayuki) → review+
Comment 7•3 years ago
|
||
mozreview-review |
Comment on attachment 8990209 [details] Bug 1469759 - Part 3. Remove unused methods of mozISpellI18NUtil. https://reviewboard.mozilla.org/r/255238/#review262138 ::: commit-message-160ac:1 (Diff revision 1) > +Bug 1469759 - Part 3. Remove unused method of mozISpellI18NUtil. r?masayuki nit: s/method/methods ::: extensions/spellcheck/src/mozEnglishWordUtils.cpp:29 (Diff revision 1) > NS_IMPL_CYCLE_COLLECTION(mozEnglishWordUtils, > mURLDetector) > > mozEnglishWordUtils::mozEnglishWordUtils() > { > - mLanguage.AssignLiteral("en"); > + mURLDetector = do_CreateInstance(MOZ_TXTTOHTMLCONV_CONTRACTID); Another approach is, to use initialization list. But up to you.
Attachment #8990209 -
Flags: review?(masayuki) → review+
Comment 8•3 years ago
|
||
mozreview-review |
Comment on attachment 8990210 [details] Bug 1469759 - Part 4. Get rid of mozISpellI18NUtil. https://reviewboard.mozilla.org/r/255240/#review262140 Really nice. Thank you!
Attachment #8990210 -
Flags: review?(masayuki) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 11•3 years ago
|
||
Pushed by m_kato@ga2.so-net.ne.jp: https://hg.mozilla.org/integration/autoland/rev/c40c74e6f347 Part 1. Use mozEnglishWordUtils directly. r=masayuki https://hg.mozilla.org/integration/autoland/rev/91eb438b6af0 Part 2. Get rid of mozISpellI18NManager. r=masayuki https://hg.mozilla.org/integration/autoland/rev/b68d9811ac08 Part 3. Remove unused methods of mozISpellI18NUtil. r=masayuki https://hg.mozilla.org/integration/autoland/rev/f1cce2949d23 Part 4. Get rid of mozISpellI18NUtil. r=masayuki
Comment 12•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c40c74e6f347 https://hg.mozilla.org/mozilla-central/rev/91eb438b6af0 https://hg.mozilla.org/mozilla-central/rev/b68d9811ac08 https://hg.mozilla.org/mozilla-central/rev/f1cce2949d23
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Updated•3 years ago
|
status-firefox62:
affected → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•