1469783 - When navigating search engines when searching via Awesome Bar, the icons do not loop infinitely when going down (Nightly 62.0a1)

Status: RESOLVED WORKSFORME

(Firefox :: Address Bar, defect, P5)

Description

[Andy Lu]

Attachment: Capture.PNG

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:62.0) Gecko/20100101 Firefox/62.0
Build ID: 20180618220118

Steps to reproduce:

1. Type something in the Awesome Bar
2. Press and hold the ctrl key and press the down arrow button repeatedly
3. Blue square highlight will disappear once it reaches the bottom of the list


Actual results:

Blue square will disappear once it goes past the bottom of the gear icon.


Expected results:

Just like when navigating the search engines using the same ctrl key, but with the up arrow, the blue square should come back around from the other side.

Comment 1

[Drew Willcoxon :adw]

Confirming -- as comment 0 says, this happens with the Ctrl key, not Alt, and it's not platform dependent.  But I had to move the selection into the one-off buttons first before starting to hold down Ctrl.

We handle Up and Down slightly differently, which is why this isn't a problem with Up.  After you move down through all the buttons and there's no selection anymore, we end up here when you press Down, which cancels the keypress and leaves the selection empty: https://dxr.mozilla.org/mozilla-central/rev/681eb7dfa324dd50403c382888929ea8b8b11b00/browser/components/search/content/search.xml#2039

But after you move up through all the buttons and the selection is empty, we end up here and we continue to advance the selection: https://dxr.mozilla.org/mozilla-central/rev/681eb7dfa324dd50403c382888929ea8b8b11b00/browser/components/search/content/search.xml#1975

Comment 2

[Florencia Di Ciocco, NI to vbalducci]

Hi, I think that this bug is no longer valid in the face of the latest changes on the browser. If I'm mistaken, please reopen it.
Regards, Flor.