1469789 - Doing animation restyles even when the animation has no valid properties.

Status: NEW

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Emilio Cobos Álvarez [:emilio]]

From bug 1469076, whose crashtest contains a line like:

  a.parentElement.animate({"ping": [0, 1]}, 0.281207776578);

> I wonder if it's expected that we do animation restyles when the animation doesn't have any valid properties in it like this.

Is it expected? :)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Hiro, Brian, do you know if comment 0 is expected? It may be the case that we can optimize stuff out and just isn't worth the complexity. I'd be fine with that :)

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Of course not.  In normal styling (i.e. kicked by refresh driver's tick), we do skip restyles for such animations [1], but we don't skip restyling in force flush?

[1] https://searchfox.org/mozilla-central/source/dom/animation/KeyframeEffect.cpp#183

Comment 3

[Brian Birtles (:birtles)]

As Hiro points out, we definitely shouldn't do animation restyles in that case.