Migrate <tabbox> to a Custom Element

RESOLVED FIXED in Firefox 63

Status

()

P3
normal
RESOLVED FIXED
9 months ago
7 months ago

People

(Reporter: bgrins, Assigned: bgrins)

Tracking

(Blocks: 1 bug)

unspecified
mozilla63
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

9 months ago
This looks like a good candidate for Custom Element conversion: https://bgrins.github.io/xbl-analysis/tree/#tabbox

- bound to a single element (tabbox)
- no <content>
- no [implements]
(Assignee)

Updated

9 months ago
Depends on: 1413418
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Priority: -- → P3
(Assignee)

Comment 6

7 months ago
MozReview-Commit-ID: HNDiMYmKgkg
(Assignee)

Updated

7 months ago
Attachment #8986530 - Attachment is obsolete: true
(Assignee)

Updated

7 months ago
Attachment #8986531 - Attachment is obsolete: true
(Assignee)

Updated

7 months ago
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
(Assignee)

Comment 7

7 months ago
Arshad, there's one consumer in mail that extends the tabbox xbl binding. It looks like it only changes one property (`tabs`): https://searchfox.org/comm-central/rev/b0a715472ce3bfd64760f0091bddee2ac012434a/mail/base/content/tabmail.xml#1826

I'm fairly sure that could be achieved by setting the [tabcontainer] attribute on the DOM node that gets that binding attached (as per this getter https://searchfox.org/mozilla-central/rev/3fa761ade83ed0b8ab463acb057c2cf0b104689e/toolkit/content/widgets/tabbox.xml#44-46). If not, you should be able to set an expando property on the DOM node from JS (override node.tabs to be a getter that returns the right thing. Last option would be to port the current tabbox XBL binding over to comm-central and somehow avoid loading the Custom Element from toolkit/.
Flags: needinfo?(arshdkhn1)
Ok! I'll work on this tomorrow. Thanks for letting me know the possible approaches of conversion.
Flags: needinfo?(arshdkhn1)
(Assignee)

Comment 12

7 months ago
In phab it still shows up as "This revision now requires changes to proceed." but I pushed an update to the patch which I thought would re-flag it for you. Marking needinfo to make sure it shows up on your radar.
Flags: needinfo?(dao+bmo)
Comment on attachment 9003177 [details]
Bug 1469902 - Migrate <tabbox> to a Custom Element;r=dao

Dão Gottwald [::dao] has approved the revision.
Attachment #9003177 - Flags: review+
Comment on attachment 9003189 [details]
Bug 1469902 - hg cp tabbox.xml -> tabbox.js to preserve blame

Dão Gottwald [::dao] has approved the revision.
Attachment #9003189 - Flags: review+
Flags: needinfo?(dao+bmo)
Attachment #9003177 - Attachment description: Bug 1469902 - Migrate <tabbox> to a Custom Element → Bug 1469902 - Migrate <tabbox> to a Custom Element;r=dao
Attachment #9003189 - Attachment is obsolete: true
(Assignee)

Updated

7 months ago
Blocks: 1486845

Comment 15

7 months ago
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/373020acb086
Migrate <tabbox> to a Custom Element;r=dao

Comment 16

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/373020acb086
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63

Comment 17

7 months ago
Hmm, no tabs in Thunderbird any more and no warning :-(

Comment 18

7 months ago
(In reply to Jorg K (GMT+2) from comment #17)
> Hmm, no tabs in Thunderbird any more and no warning :-(

See comment 7.

Comment 19

7 months ago
(In reply to Tim Nguyen :ntim from comment #18)
> See comment 7.
Right, sorry. In the future please CC me and Richard as well.
You need to log in before you can comment on or make changes to this bug.