46 bytes, text/x-phabricator-request
|Details | Review|
This looks like a good candidate for Custom Element conversion: https://bgrins.github.io/xbl-analysis/tree/#tabbox - bound to a single element (tabbox) - no <content> - no [implements]
This works, but leaks in debug builds. I think that's due to Bug 1413418: https://treeherder.mozilla.org/#/jobs?repo=try&revision=173e7ed0efd270f79933051d3a13e191f0602aba
Leak seems to go away with the patch in Bug 1413418 applied. Before: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5f2682c84de93c905b8e98afa823270df9418603 After: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6375fb7cfb1001d0b145a101b914c9b4d8046a71
Attachment #8986530 - Attachment is obsolete: true
Attachment #8986531 - Attachment is obsolete: true
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Arshad, there's one consumer in mail that extends the tabbox xbl binding. It looks like it only changes one property (`tabs`): https://searchfox.org/comm-central/rev/b0a715472ce3bfd64760f0091bddee2ac012434a/mail/base/content/tabmail.xml#1826 I'm fairly sure that could be achieved by setting the [tabcontainer] attribute on the DOM node that gets that binding attached (as per this getter https://searchfox.org/mozilla-central/rev/3fa761ade83ed0b8ab463acb057c2cf0b104689e/toolkit/content/widgets/tabbox.xml#44-46). If not, you should be able to set an expando property on the DOM node from JS (override node.tabs to be a getter that returns the right thing. Last option would be to port the current tabbox XBL binding over to comm-central and somehow avoid loading the Custom Element from toolkit/.
Ok! I'll work on this tomorrow. Thanks for letting me know the possible approaches of conversion.
In phab it still shows up as "This revision now requires changes to proceed." but I pushed an update to the patch which I thought would re-flag it for you. Marking needinfo to make sure it shows up on your radar.
Comment on attachment 9003177 [details] Bug 1469902 - Migrate <tabbox> to a Custom Element;r=dao Dão Gottwald [::dao] has approved the revision.
Attachment #9003177 - Flags: review+
Comment on attachment 9003189 [details] Bug 1469902 - hg cp tabbox.xml -> tabbox.js to preserve blame Dão Gottwald [::dao] has approved the revision.
Attachment #9003189 - Flags: review+
Attachment #9003177 - Attachment description: Bug 1469902 - Migrate <tabbox> to a Custom Element → Bug 1469902 - Migrate <tabbox> to a Custom Element;r=dao
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/373020acb086 Migrate <tabbox> to a Custom Element;r=dao
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Hmm, no tabs in Thunderbird any more and no warning :-(
(In reply to Jorg K (GMT+2) from comment #17) > Hmm, no tabs in Thunderbird any more and no warning :-( See comment 7.
(In reply to Tim Nguyen :ntim from comment #18) > See comment 7. Right, sorry. In the future please CC me and Richard as well.
You need to log in before you can comment on or make changes to this bug.