Closed Bug 1469933 Opened 6 years ago Closed 6 years ago

./mach run --debugger=windbg assumes x86 build

Categories

(Testing :: Mozbase, enhancement)

enhancement
Not set
normal

Tracking

(firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: tjr, Assigned: tjr)

Details

Attachments

(1 file)

In _windbg_installation_paths() in https://searchfox.org/mozilla-central/rev/d0a41d2e7770fc00df7844d5f840067cc35ba26f/testing/mozbase/mozdebug/mozdebug/mozdebug.py#74 we hardcode the x86 version of WinDBG; which produces an error if you're trying to use this on an 64 bit build.
We should probably just flip that to try the x64 version by default. It can debug x86 binaries anyway, and we don't support building on x86 Windows nowadays.
Component: Mach Core → Mozbase
Product: Firefox Build System → Testing
Bug 1469933 When using ./mach run --debugger=windbg, use the x64 version of WinDBG r?ted
Comment on attachment 8986526 [details]
Bug 1469933 When using ./mach run --debugger=windbg, use the x64 version of WinDBG r?ted

(PTO June 23rd-30th) Ted Mielczarek [:ted.mielczarek] has approved the revision.

https://phabricator.services.mozilla.com/D1730
Attachment #8986526 - Flags: review+
Assignee: nobody → tom
Keywords: checkin-needed
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/644a1b7d6833
When using ./mach run --debugger=windbg, use the x64 version of WinDBG r=ted
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/644a1b7d6833
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: