1470005 - TRR: make blacklist duration one minute by default

Status: RESOLVED FIXED

(Core :: Networking: DNS, enhancement, P1)

Description

[Daniel Stenberg [:bagder]]

1. The normal back-off + retry mechanism works very well and is transparent enough to not make users hurt much even when not blacklisted
2. This removes "mistaken" blacklist entries faster
3. The new expiration timeout is set to mostly survive a page load and a little more.

Comment 1

[Daniel Stenberg [:bagder]]

Attachment: bug 1470005 - change default TRR blacklist duration to 60 seconds

Review commit: https://reviewboard.mozilla.org/r/251878/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/251878/

Comment 2

[Patrick McManus [:mcmanus]]

Comment on attachment 8986590 [details]
bug 1470005 - change default TRR blacklist duration to 60 seconds

https://reviewboard.mozilla.org/r/251878/#review258336

::: modules/libpref/init/all.js:5303
(Diff revision 1)
>  // from the DOH end point to ensure proper configuration
>  pref("network.trr.confirmationNS", "example.com");
>  // hardcode the resolution of the hostname in network.trr.uri instead of
>  // relying on the system resolver to do it for you
>  pref("network.trr.bootstrapAddress", "");
> -// TRR blacklist entry expire time (in seconds). Default is 20 minutes.
> +// TRR blacklist entry expire time (in seconds). Default is one minute.

adjust the comment to indicate we're just looking for locality around a page load

Comment 3

[Daniel Stenberg [:bagder]]

Comment on attachment 8986590 [details]
bug 1470005 - change default TRR blacklist duration to 60 seconds

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/251878/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e09fbaee1456
change default TRR blacklist duration to 60 seconds r=mcmanus

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e09fbaee1456