1470068 - Rename LOCAL_EME_SOURCES in ProductAddonChecker to LOCAL_GMP_SOURCES

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, enhancement, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Chris Pearce (:cpearce) from bug 1467700 comment #11)
> (In reply to Henrik Skupin (:whimboo) from comment #7)
> > (In reply to Henrik Skupin (:whimboo) from comment #6)
> > > For EME plugins we basically need another pref which is `media.eme.enabled`.
> > 
> > Interesting that the addon manager repository lists all of the above
> > mentioned plugins as EME:
> > 
> > https://dxr.mozilla.org/mozilla-central/rev/
> > 75a32b57132f8cba42779555662a057a0416a313/toolkit/mozapps/extensions/internal/
> > ProductAddonChecker.jsm#9-15
> 
> This list is to provide a download location in the case where we can't
> connect to the GMP update server/AUS to get the latest list of GMP/CDM
> download locations. OpenH264 is not an EME plugin, so I think this list is
> misleadingly named; it's deliberately supposed to include both Widevine and
> OpenH264, and only one of those in an EME plugin.
> 
> 
> > So why does disabling EME not also disable the openh264 plugin? Also I can
> > set "media.gmp-manager.url.override" to an empty string or
> > "media.gmp-gmpopenh264.enabled" to false, but Firefox always downloads this
> > plugin.
> 
> OpenH264 is not an EME plugin, so it shouldn't be disabled when EME is
> disabled. OpenH264 is used by WebRTC, not EME.
> 
> If the download of the plugin list from AUS fails, we'll use the
> LOCAL_EME_SOURCES list to find a location to download the plugin from. (AUS
> was down for 3 weeks once, and that stopped new installs of Firefox from
> being able to play Netflix, which is why we have this fallback path for
> GMP/CDM downloads).
> 
>  
> > There is something really wrong here in Firefox I assume. Personally I would
> > only expect to have to set `media.eme.enabled` to `false` to stop all
> > downloads. But as it looks like it is `media.gmp-manager.updateEnabled`
> > which has to be set:
> > 
> > https://dxr.mozilla.org/mozilla-central/rev/
> > 75a32b57132f8cba42779555662a057a0416a313/toolkit/mozapps/extensions/internal/
> > ProductAddonChecker.jsm#231-234
> > 
> > Stephen, maybe you could have another look? Let me know if I should file a
> > bug for Firefox. Thanks.
> 
> Based on a quick look at the AddonChecker code, it seems that
> media.gmp-manager.updateEnabled is what you need to set. So I think your
> patch is the right approach.
> 
> I think the only thing wrong here is that LOCAL_EME_SOURCES is misleadingly
> named. I think it would be a good idea to rename it to LOCAL_GMP_SOURCES (or
> somesuch) while you're here to clear up future confusion.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1470068 - Rename LOCAL_EME_SOURCES in ProductAddonChecker to LOCAL_GMP_SOURCES.

OpenH264 is not an EME plugin. So listing it under LOCAL_EME_SOURCES
is not appropriate and confusing.

Given that both OpenH264 and WideVine plugins are handled by the GMP
manager, the name of the local sources list should be named like it.

Review commit: https://reviewboard.mozilla.org/r/251972/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/251972/

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8986667 [details]
Bug 1470068 - Rename LOCAL_EME_SOURCES in ProductAddonChecker to LOCAL_GMP_SOURCES.

https://reviewboard.mozilla.org/r/251972/#review258418

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dff46afaa69c
Rename LOCAL_EME_SOURCES in ProductAddonChecker to LOCAL_GMP_SOURCES. r=cpearce

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/dff46afaa69c