Closed Bug 1470068 Opened 4 years ago Closed 4 years ago

Rename LOCAL_EME_SOURCES in ProductAddonChecker to LOCAL_GMP_SOURCES


(Toolkit :: Add-ons Manager, enhancement, P2)




Tracking Status
firefox62 --- fixed


(Reporter: whimboo, Assigned: whimboo)




(1 file)

(In reply to Chris Pearce (:cpearce) from bug 1467700 comment #11)
> (In reply to Henrik Skupin (:whimboo) from comment #7)
> > (In reply to Henrik Skupin (:whimboo) from comment #6)
> > > For EME plugins we basically need another pref which is `media.eme.enabled`.
> > 
> > Interesting that the addon manager repository lists all of the above
> > mentioned plugins as EME:
> > 
> >
> > 75a32b57132f8cba42779555662a057a0416a313/toolkit/mozapps/extensions/internal/
> > ProductAddonChecker.jsm#9-15
> This list is to provide a download location in the case where we can't
> connect to the GMP update server/AUS to get the latest list of GMP/CDM
> download locations. OpenH264 is not an EME plugin, so I think this list is
> misleadingly named; it's deliberately supposed to include both Widevine and
> OpenH264, and only one of those in an EME plugin.
> > So why does disabling EME not also disable the openh264 plugin? Also I can
> > set "media.gmp-manager.url.override" to an empty string or
> > "media.gmp-gmpopenh264.enabled" to false, but Firefox always downloads this
> > plugin.
> OpenH264 is not an EME plugin, so it shouldn't be disabled when EME is
> disabled. OpenH264 is used by WebRTC, not EME.
> If the download of the plugin list from AUS fails, we'll use the
> LOCAL_EME_SOURCES list to find a location to download the plugin from. (AUS
> was down for 3 weeks once, and that stopped new installs of Firefox from
> being able to play Netflix, which is why we have this fallback path for
> GMP/CDM downloads).
> > There is something really wrong here in Firefox I assume. Personally I would
> > only expect to have to set `media.eme.enabled` to `false` to stop all
> > downloads. But as it looks like it is `media.gmp-manager.updateEnabled`
> > which has to be set:
> > 
> >
> > 75a32b57132f8cba42779555662a057a0416a313/toolkit/mozapps/extensions/internal/
> > ProductAddonChecker.jsm#231-234
> > 
> > Stephen, maybe you could have another look? Let me know if I should file a
> > bug for Firefox. Thanks.
> Based on a quick look at the AddonChecker code, it seems that
> media.gmp-manager.updateEnabled is what you need to set. So I think your
> patch is the right approach.
> I think the only thing wrong here is that LOCAL_EME_SOURCES is misleadingly
> named. I think it would be a good idea to rename it to LOCAL_GMP_SOURCES (or
> somesuch) while you're here to clear up future confusion.
Assignee: nobody → hskupin
Priority: -- → P2
Comment on attachment 8986667 [details]
Bug 1470068 - Rename LOCAL_EME_SOURCES in ProductAddonChecker to LOCAL_GMP_SOURCES.
Attachment #8986667 - Flags: review?(cpearce) → review+
Pushed by
Rename LOCAL_EME_SOURCES in ProductAddonChecker to LOCAL_GMP_SOURCES. r=cpearce
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.