1470084 - It is possible to create a diff from cinnabar repository using standard arcanist

Status: RESOLVED FIXED

(Conduit :: Phabricator, defect)

Description

[Piotr Zalewa [:zalun]]

Found by :kimberlythegeek when following the TestPlan [1] T13.

It is possible to create the diff with an unmodified arc in the `phabricator-qa-dev` repository cloned with `git-cinnabar`.

```
$ git clone hg::https://hg.mozilla.org/automation/phabricator-qa-dev/ phabricator-qa-dev-cinnabar
$ cd phabricator-qa-dev-cinnabar/
$ echo x >> README.md
$ git commit -am x
$ arc diff HEAD~ --create
```

It should fail with a message:
```
ERR-CONDUIT-CORE: Local VCS (git) is different from the one defined in the repository (hg).
To use Phabricator with git-cinnabar please follow the docs at https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html#using-git-cinnabar
```

This error is displayed under following conditions:
1. Repository callsign has to be specified in the `.arcconfig` file
2. Repository on the Phabricator has to be configured as Mercurial
3. `arc` command has to use the Arcanist from Phacility (not modified by Mozilla)
4. Phabricator has to be patched with the `1458191_1.patch` [2]

[1] https://wiki.mozilla.org/Phabricator/TestPlan#T13_-_Creating_a_Diff_from_local_git_repository_to_remote_Mercurial_repository_is_not_allowed
[2] https://github.com/mozilla-services/phabricator-extensions/blob/master/patches/phabricator/1458191_1.patch

Comment 1

[Piotr Zalewa [:zalun]]

I'm unable to replicate this issue in local development environment (Conduit Suite). 
I've tried using both - local Phabricator repository and the `mozilla/phabext` image.
As long as the conditions mentioned above are met the error is raised.
The patch is implemented just before the `Promote 2018 Week 19` in commit `e2c25a0b` [1]

[1] https://github.com/mozilla-services/phabricator-extensions/commit/e2c25a0bd820e7bdf11643ebc966dcbeddd6f663

Comment 2

[Piotr Zalewa [:zalun]]

Repository callsign in `phabricator-qa-dev` was set to "PHABRICATORQADEV".
Phabricator had it configured as "PHABRICATORQA".

:dkl will change the Phabricator repository configuration to match the one defined in the Mercurial.

Comment 3

[David Lawrence [:dkl]]

(In reply to Piotr Zalewa [:zalun] from comment #2)
> Repository callsign in `phabricator-qa-dev` was set to "PHABRICATORQADEV".
> Phabricator had it configured as "PHABRICATORQA".
> 
> :dkl will change the Phabricator repository configuration to match the one
> defined in the Mercurial.

I have update phabricator-dev to the proper values.

dkl