Closed Bug 1470098 Opened 2 years ago Closed 2 years ago

[wdspec] Refactor user prompt tests

Categories

(Testing :: geckodriver, enhancement, P1)

enhancement

Tracking

(firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

Attachments

(5 files)

We already have a couple of user prompt tests implemented but those differ a lot between the individual commands. We should refactor them to make it easier to get the remaining ones implemented. This would involve using fixtures, and shared code.
Attachment #8989983 - Flags: review?(ato)
Attachment #8989984 - Flags: review?(ato)
Attachment #8989985 - Flags: review?(ato)
Attachment #8989986 - Flags: review?(ato)
Attachment #8989987 - Flags: review?(ato)
Comment on attachment 8989983 [details]
Bug 1470098 - [wdspec] Change create_dialog and assert_dialog_handled to make use of available wdclient commands.

https://reviewboard.mozilla.org/r/255008/#review261862

::: commit-message-6c0fa:3
(Diff revision 1)
> +Both the 'create_dialog' and 'assert_dialog_handled' methods
> +have to use the wdclient and not transport methods.

Have to?
Attachment #8989983 - Flags: review?(ato) → review+
Comment on attachment 8989984 [details]
Bug 1470098 - [wdspec] Parametrize user prompt tests.

https://reviewboard.mozilla.org/r/255010/#review261864
Attachment #8989984 - Flags: review?(ato) → review+
Comment on attachment 8989985 [details]
Bug 1470098 - [wdspec] Sort user prompt tests and add placeholders for missing tests.

https://reviewboard.mozilla.org/r/255012/#review261866
Attachment #8989985 - Flags: review?(ato) → review+
Comment on attachment 8989986 [details]
Bug 1470098 - [wdspec] Add tests for confirm, and prompt for the Execute (Async) Script commands.

https://reviewboard.mozilla.org/r/255014/#review261868
Attachment #8989986 - Flags: review?(ato) → review+
Comment on attachment 8989987 [details]
Bug 1470098 - [wdspec] Update MANIFEST.json.

https://reviewboard.mozilla.org/r/255016/#review261870
Attachment #8989987 - Flags: review?(ato) → review+
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2117e7cf0c29
[wdspec] Change create_dialog and assert_dialog_handled to make use of available wdclient commands. r=ato
https://hg.mozilla.org/integration/autoland/rev/4fa1a25c3927
[wdspec] Parametrize user prompt tests. r=ato
https://hg.mozilla.org/integration/autoland/rev/368e0114f843
[wdspec] Sort user prompt tests and add placeholders for missing tests. r=ato
https://hg.mozilla.org/integration/autoland/rev/ca9e5be7f556
[wdspec] Add tests for confirm, and prompt for the Execute (Async) Script commands. r=ato
https://hg.mozilla.org/integration/autoland/rev/355ee8398823
[wdspec] Update MANIFEST.json. r=ato
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/11992 for changes under testing/web-platform/tests
Upstream PR merged
You need to log in before you can comment on or make changes to this bug.