Closed Bug 1470121 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 11603 - Add tests for Element.toggleAttribute.

Categories

(Core :: DOM: Core & HTML, enhancement, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 11603 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/11603
Details from upstream follow.

Jonathan Kingston <jonathan@jooped.co.uk> wrote:
>  Add tests for Element.toggleAttribute.
>  
>  https://dom.spec.whatwg.org/#dom-element-toggleattribute
Component: web-platform-tests → DOM
Product: Testing → Core
Ran 1 tests and 67 subtests
OK     : 1
PASS   : 57
FAIL   : 10

New tests that have failures or other problems:
/dom/nodes/attributes.html
    Basic functionality should be intact. (toggleAttribute): FAIL
    When qualifiedName does not match the Name production, an INVALID_CHARACTER_ERR exception is to be thrown, even if the attribute is already present. (toggleAttribute): FAIL
    When qualifiedName does not match the Name production, an INVALID_CHARACTER_ERR exception is to be thrown. (toggleAttribute): FAIL
    toggleAttribute should lowercase its name argument (mixed case attribute): FAIL
    toggleAttribute should lowercase its name argument (upper case attribute): FAIL
    toggleAttribute should not change the order of previously set attributes.: FAIL
    toggleAttribute should not throw even when qualifiedName starts with 'xmlns': FAIL
    toggleAttribute should set the attribute with the given qualified name: FAIL
    toggleAttribute should set the first attribute with the given name: FAIL
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8b93c6579448
[wpt PR 11603] - Add tests for Element.toggleAttribute., a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/8045d8bcb10d
[wpt PR 11603] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/8b93c6579448
https://hg.mozilla.org/mozilla-central/rev/8045d8bcb10d
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.