Closed Bug 1470125 Opened Last year Closed Last year

Update webrender to cdfaaeb5f74e416f39af1081c9a676c752d23896

Categories

(Core :: Graphics: WebRender, enhancement, P3)

62 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox62 --- wontfix
firefox63 --- fixed

People

(Reporter: kats, Assigned: kats)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [gfx-noted])

Attachments

(3 files)

+++ This bug was initially created as a clone of Bug #1468950 +++

I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh
WR @ 46a967abf28b1b87b23901839ee6eee79ce9bd35

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e989ff39da6b5c43911c03c9c1efa133a7e15adf

Crashtest failures, from servo/webrender#2847


WR @ a49d00990a8f79ce76f1bd10d4473b8935ca1aed

https://treeherder.mozilla.org/#/jobs?repo=try&revision=59c37219cfb030da5d43c4783b65bf95acbecea3

Build bustage, from servo/webrender#2849 - requires a bindings.rs change which I will apply on the next try push
WR @ a185cfb72f9c05410a854d7873bf8aed3bfd7a21

https://treeherder.mozilla.org/#/jobs?repo=try&revision=65c7756aa6b115de5d5957f8a247033a3c29da3e

Build bustage is fixed, crashtests are still failing, since this push doesn't have servo/webrender#2853.
Alias: wr-future-update
Assignee: nobody → bugmail
Summary: Future webrender update bug → Update webrender to cdfaaeb5f74e416f39af1081c9a676c752d23896
Comment on attachment 8988473 [details]
Bug 1470125 - Update webrender to commit cdfaaeb5f74e416f39af1081c9a676c752d23896.

https://reviewboard.mozilla.org/r/253754/#review260414
Attachment #8988473 - Flags: review?(a.beingessner) → review+
Comment on attachment 8988474 [details]
Bug 1470125 - Update bindings for changes in WR PR 2849.

https://reviewboard.mozilla.org/r/253756/#review260418
Attachment #8988474 - Flags: review?(a.beingessner) → review+
Comment on attachment 8988475 [details]
Bug 1470125 - Update WR bindings for changes in WR PR 2848.

https://reviewboard.mozilla.org/r/253758/#review260422

::: gfx/webrender_bindings/src/bindings.rs:2208
(Diff revision 1)
>      debug_assert!(unsafe { is_in_main_thread() });
>  
>      let stops_slice = make_slice(stops, stops_count);
>      let stops_vector = stops_slice.to_owned();
>  
> -    let border_details =
> +    let slice = SideOffsets2D::new( widths.top as u32,

could you give this a more descriptive name? (sides?)
Comment on attachment 8988475 [details]
Bug 1470125 - Update WR bindings for changes in WR PR 2848.

https://reviewboard.mozilla.org/r/253758/#review260424
Attachment #8988475 - Flags: review?(a.beingessner) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/82527f62f249
Update webrender to commit cdfaaeb5f74e416f39af1081c9a676c752d23896. r=Gankro
https://hg.mozilla.org/integration/autoland/rev/cb8bed4a7691
Update bindings for changes in WR PR 2849. r=Gankro
https://hg.mozilla.org/integration/autoland/rev/c6ef35a760ae
Update WR bindings for changes in WR PR 2848. r=Gankro
Backed out 3 changesets (bug 1470125) for force-cargo-library-build bustages on a CLOSED TREE

Problematic push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=c6ef35a760aecc90c41398b4cd4af1be1a03753f&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified
Failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified&fromchange=6bcf0177fc94c7fc4da19057699de0b12a3c3d7a&selectedJob=185404284
Log: https://treeherder.mozilla.org/logviewer.html#?job_id=185404350&repo=autoland&lineNumber=18574
Backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=27f60c02583dca519ae203bcf34ac8133483f0e7&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified

[task 2018-06-28T18:21:09.878Z] 18:21:09     INFO -  make[4]: *** [force-cargo-library-build] Error 101
[task 2018-06-28T18:21:09.878Z] 18:21:09     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/library/gtest/rust'
[task 2018-06-28T18:21:09.879Z] 18:21:09     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/gfx/skia'
[task 2018-06-28T18:21:09.879Z] 18:21:09     INFO -  /builds/worker/workspace/build/src/config/recurse.mk:74: recipe for target 'toolkit/library/gtest/rust/target' failed
[task 2018-06-28T18:21:09.879Z] 18:21:09     INFO -  make[3]: *** [toolkit/library/gtest/rust/target] Error 2
[task 2018-06-28T18:21:09.880Z] 18:21:09     INFO -  make[3]: *** Waiting for unfinished jobs....
Flags: needinfo?(bugmail)
I guess that's why it was called "slice"... :/
Flags: needinfo?(bugmail)
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/afe2313f83ed
Update webrender to commit cdfaaeb5f74e416f39af1081c9a676c752d23896. r=Gankro
https://hg.mozilla.org/integration/autoland/rev/720f0dd717a1
Update bindings for changes in WR PR 2849. r=Gankro
https://hg.mozilla.org/integration/autoland/rev/ba2b15dbe7d8
Update WR bindings for changes in WR PR 2848. r=Gankro
You need to log in before you can comment on or make changes to this bug.