1470174 - "Clear private data on exit" does not delete icon cache (at cache/icons/)

Status: RESOLVED MOVED

(Firefox for Android Graveyard :: Favicon Handling, defect)

Description

[Rob Wu [:robwu]]

(blocked on bug 1466130 because the relevant code is being refactored)

The "Clear private data on exit" option in Fennec does not wipe the cache/icons/ directory (created by https://searchfox.org/mozilla-central/rev/d0a41d2e7770fc00df7844d5f840067cc35ba26f/mobile/android/base/java/org/mozilla/gecko/icons/storage/DiskStorage.java#71 ).

In contrast, the "Clear Private Data" action (via the menu) does wipe the cache (when the "Offline Website Data" is selected):
https://searchfox.org/mozilla-central/rev/d0a41d2e7770fc00df7844d5f840067cc35ba26f/mobile/android/base/java/org/mozilla/gecko/preferences/PrivateDataPreference.java#55-58


To make sure that the data is wiped in both cases ("Clear private data on exit" and "Clear Private Data" menu item), the icon cleanup logic should be triggered from Sanitizer.jsm (maybe at a (new?) cache category instead of the "Offline Website Data" category).

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

I made this a private bug because it is similar to bug 1448305.

Comment 2

[Daniel Veditz [:dveditz]]

Keeping hidden because it reveals bug 1448305, but this one is more "just a bug" than a security problem.

Comment 3

[Rob Wu [:robwu]]

Andrea, your bug (bug 1466130) blocks this bug. Are you able to fix bug 1466130 in Firefox 63?
I'd like to get the fix for this bug and bug 1448305 in the same release (63), so that the known issues with leaks of private icons are fixed in the same release.

Comment 4

[Kevin Brosnan [Ex-Mozilla]]

Fixed on Fenix by https://github.com/mozilla-mobile/android-components/issues/7766

Comment 5

[Rob Wu [:robwu]]

Thanks for the feedback Kevin.

Since the bug got fixed such a long time ago, it would probably be fine to open this bug to the public.