Closed Bug 1470207 Opened 6 years ago Closed 6 years ago

Finalize images and strings for error screens

Categories

(Firefox :: WebPayments UI, defect, P1)

Product:
Firefox
Component:
WebPayments UI
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 63
Tracking Flags:
Tracking Status
firefox63 --- verified

People

(Reporter: epang, Assigned: jaws)

References

Details

(Whiteboard: [webpayments] [user-testing])

Attachments

(3 files)

error_screens.png
213.87 KB, image/png
Details
Icon_Assets.zip
17.72 KB, application/zip
Details
Bug 1470207 - Use final images for error and timeout screens. r?MattN
46 bytes, text/x-phabricator-request
MattN
: review+
Details | Review 
Create final images to be used on error screens
- Failure 
- Timeout
Priority: P1 → P2
status-firefox62: affected → ---
Whiteboard: [webpayments] [ux] → [webpayments] [ux] [user-testing]
Summary: Finalize images for error screens → Finalize images and strings for error screens
Flags: qe-verify+
QA Contact: hani.yacoub
Depends on: 1447777
Priority: P2 → P3
Whiteboard: [webpayments] [ux] [user-testing] → [webpayments-reserve] [ux] [user-testing]
Attached image error_screens.png — 
Updated images and copy for error screens

Link to spec: 
https://mozilla.invisionapp.com/share/S5FXRY0D8TZ#/304878932_7-2_Checkout_-_Faliure
Attached file Icon_Assets.zip — 
Svgs for the images
Whiteboard: [webpayments-reserve] [ux] [user-testing] → [webpayments-reserve] [user-testing]
Priority: P3 → P2
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Priority: P2 → P1
Whiteboard: [webpayments-reserve] [user-testing] → [webpayments] [user-testing]
Comment on attachment 9004619 [details]
Bug 1470207 - Use final images for error and timeout screens. r?MattN

Matthew N. [:MattN] (PM if requests are blocking you) has approved the revision.
Attachment #9004619 - Flags: review+
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/fb811847c1e4
Use final images for error and timeout screens. r=MattN
https://hg.mozilla.org/mozilla-central/rev/fb811847c1e4
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
I can confirm that the images for failure/timeout are displayed, but the strings that are displayed to tell the user what went wrong are not matching the spec.

I used this test page to verify this bug "https://bug1447777.bmoattachments.org/attachment.cgi?id=8988961"
and in this test page we don't have a case where "close" or "Back to Checkout" buttons are displayed to verify that also.

Should I only verify that the images for failure/timeout are displayed in this bug?
Flags: needinfo?(jaws)
The "Back to Checkout" button will only show when the "Retry" capability is implemented, which it is not yet (see bug 1435163).

The button that does show should be "Close" instead of "OK". Can you file a bug for changing the button text to "Close"?
Flags: needinfo?(jaws) → needinfo?(hani.yacoub)
I logged bug 1487395 for that.
How about the strings that are displayed to tell the user what went wrong? Is this also handled in another bug?
Flags: needinfo?(hani.yacoub) → needinfo?(jaws)
Sorry I didn't notice that the strings have changed again. Let's use bug 1487395 for that as well.
Flags: needinfo?(jaws)
Verified as fixed on Firefox Nightly 63.0a1 on Windows 10 x 64, Windows 7 x32, Mac OS X 10.12 and Ubuntu 18.04 x64.

I logged bug 1487395 to handle:
1. "Close" button should be displayed instead of "OK" button when payment failed.
2. The strings that are displayed to tell the user what went wrong to match the spec.
Status: RESOLVED → VERIFIED
status-firefox63: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: