1470234 - handle empty headers correctly when automatically copying headers to InterceptedHttpChannel

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

In bug 1468828 I added some automatic header copying when the nsHttpChannel does its special internal redirect to InterceptedHttpChannel.  I did not, however, handle empty headers correctly there.  A mochitest is failing because empty headers are being silently dropped during this copy operation.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Handle empty headers correctly when auto-copying headers for special internal redirect to InterceptedHttpChannel. r=valentin

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8986837 [details] [diff] [review]
Handle empty headers correctly when auto-copying headers for special internal redirect to InterceptedHttpChannel. r=valentin

Valentin, this fixes a silly mistake in the previous bug.  We need to call SetEmptyRequestHeader() when appropriate.

Comment 3

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8986837 [details] [diff] [review]
Handle empty headers correctly when auto-copying headers for special internal redirect to InterceptedHttpChannel. r=valentin

Review of attachment 8986837 [details] [diff] [review]:
-----------------------------------------------------------------

That's cool. Do we already have WPT tests that trigger this?

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

No WPT test for it.  The mochitest that triggered it is:

  dom/tests/mochitest/fetch/test_fetch_cors_sw_reroute.html

At this subtest (plus a few other empty header ones in the same file):

  https://searchfox.org/mozilla-central/rev/d0a41d2e7770fc00df7844d5f840067cc35ba26f/dom/tests/mochitest/fetch/test_fetch_cors.js#277

I don't think I have time to convert the mochitest to a WPT at the moment, though.

Comment 5

[Valentin Gosu [:valentin] (he/him)]

If we have at least one test for it, that's fine. :)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ea5d5eea145b
Handle empty headers correctly when auto-copying headers for special internal redirect to InterceptedHttpChannel. r=valentin

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/ea5d5eea145b