Closed
Bug 1470254
Opened 6 years ago
Closed 6 years ago
don't send push events to child process when service workers is in parent-process mode
Categories
(Core :: DOM: Service Workers, enhancement)
Core
DOM: Service Workers
Tracking
()
RESOLVED
FIXED
mozilla62
Tracking | Status | |
---|---|---|
firefox62 | --- | fixed |
People
(Reporter: bkelly, Assigned: bkelly)
References
Details
Attachments
(1 file)
1.83 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
Currently we always try to send push events to a content process to dispatch to SWM. With the e10s pref flipped, though, we want to just tell the parent process SWM about the push event instead.
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
Comment on attachment 8986853 [details] [diff] [review]
Don't send push events to child process when e10s pref is flipped. r=mrbkap
Blake, this patch simply avoids sending a message to the child process before calling ServiceWorkerManager::SendPushEvent(). When the e10s pref is flipped we want to just call this in the parent process directly.
Attachment #8986853 -
Flags: review?(mrbkap)
Updated•6 years ago
|
Attachment #8986853 -
Flags: review?(mrbkap) → review+
Pushed by bkelly@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ce6cfe17939
Don't send push events to child process when e10s pref is flipped. r=mrbkap
Comment 4•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•