1470268 - Add ability to filter allocations reported by dmd.py

Status: RESOLVED FIXED

(Core :: DMD, enhancement)

Description

[Eric Rahm [:erahm]]

As a user I'd like to be able to limit the output of dmd.py to only include stacks that go through certain pieces of code. For example I'd like investigate font related allocations that come from 'libfontconfig' without have to look at other allocations.

Comment 1

[Eric Rahm [:erahm]]

Attachment: Add allocation filter to dmd.py

This adds an '--allocation-filter' param that can be used to limit output to
only allocations that include the filter in their stack. For example:
  dmd.py --allocation-filter fontconfig dmd.json.gz
limits its output to just allocations that have an instance of 'fontconfig' in
in one of their stack frames.

Comment 2

[Nicholas Nethercote [inactive]]

Comment on attachment 8986879 [details] [diff] [review]
Add allocation filter to dmd.py

Review of attachment 8986879 [details] [diff] [review]:
-----------------------------------------------------------------

It would be nice to have a test, but getting reliable stacks is hard.

Comment 3

[Eric Rahm [:erahm]]

(In reply to Nicholas Nethercote [:njn] from comment #2)
> Comment on attachment 8986879 [details] [diff] [review]
> Add allocation filter to dmd.py
> 
> Review of attachment 8986879 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> It would be nice to have a test, but getting reliable stacks is hard.

I'll file a follow-up for adding pure python tests + synthetic dmd.json files.

Comment 4

[Eric Rahm [:erahm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3b8204a5fa3ab24e1d06db75a5748cb5c47a8475
Bug 1470268 - Add allocation filter to dmd.py. r=njn

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/3b8204a5fa3a