1470382 - Visibility issues inside permission doorhanger on dark theme

Status: VERIFIED FIXED

(Firefox :: Site Identity, defect, P3)

Description

[Anca Soncutean, Desktop QA]

[Affected versions]: 
- Firefox 61.0.
- Firefox 62.0b2 - dev edition
- Firefox 62.0a1 (2018-06-21)

[Affected platforms]:
- Mac OS 10.10
- Ubuntu 16.04 x64
- Windows 10 x64

[Steps to reproduce]:

Precondtions :
- If not on a Dev edition build, make sure to set the theme on dark from Menu-Customize-Themes. 

1. Go to https://mozilla.github.io/webrtc-landing/gum_test.html
2. Click on the Screen button 
3. Observe the Allow button
4. Select an option from Screen to share drop down form
5. Observe the warning message inside the yellow panel

[Expected result]:
- Step[3] and Step[6] - The texts are easy to distinguish.

[Actual result]:
- Step[3] and Step[6] - The texts are barely visible.

[Additional Notes]:
-  Screenshot with the issue: (Allow button - https://drive.google.com/open?id=11U8paKuEAH8iQaFH00Io__CV474mJzDX ) and (warning message - https://drive.google.com/open?id=1ODyabvQxJrzOjSnfHlorvad-pLgqUHIp )
- The Allow button seems to look better on 61.0b1 dev edition : https://drive.google.com/open?id=1ZutiB_CiIPnYpDqQdp-ykKp9Va7beHtP

Comment 1

[Tim Nguyen :ntim]

Attachment: Bug 1470382 - Fix visibility issues in WebRTC permission popup.

Review commit: https://reviewboard.mozilla.org/r/258386/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/258386/

Comment 2

[Johann Hofmann [:johannh]]

Comment on attachment 8993701 [details]
Bug 1470382 - Fix visibility issues in WebRTC permission popup.

https://reviewboard.mozilla.org/r/258386/#review265496

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d2058cba30e
Fix visibility issues in WebRTC permission popup. r=johannh

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/9d2058cba30e

Comment 5

[Tim Nguyen :ntim]

Comment on attachment 8993701 [details]
Bug 1470382 - Fix visibility issues in WebRTC permission popup.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1408121
[User impact if declined]: See comment 0
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: see comment 0
[List of other uplifts needed for the feature/fix]: n/a
[Is the change risky?]: low risk
[Why is the change risky/not risky?]: css only
[String changes made/needed]: nope

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8993701 [details]
Bug 1470382 - Fix visibility issues in WebRTC permission popup.

CSS fixes for better visibility, let's uplift for beta 12.

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/e84fba80aaa1

Comment 8

[Anca Soncutean, Desktop QA]

The permission doorhanger looks good now on dark theme on Firefox 63.0a1 (2018-07-26) and Firefox 62.0b12 (20180726161819) under Windows 10 x64, macOS 10.12 and Ubuntu 16.04 x64.
Note though, the screen share doorhanger  broken UI as per bug 1406899 on Linux platform: https://drive.google.com/open?id=1pOw31WfFgFSm0fTyNohnFDxWckFGPeC0 .