1470386 - Recycle TextureClient at IMFYCbCrImage

Status: RESOLVED FIXED

(Core :: Graphics: Layers, enhancement)

Description

[Sotaro Ikeda [:sotaro]]

It seems that we do not need to use IMFYCbCrImage. We could use D3D11YCbCrImage instead of IMFYCbCrImage.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Remove IMFYCbCrImage usage in WMFVideoMFTManager::CreateBasicVideoFrame()

Comment 2

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Remove IMFYCbCrImage usage in WMFVideoMFTManager::CreateBasicVideoFrame()

Comment 3

[Sotaro Ikeda [:sotaro]]

attachment 8987007 [details] [diff] [review] just calls VideoData::CreateAndCopyData() with mKnowsCompositor. With it, VideoData::CreateAndCopyData() creates D3D11YCbCrImage if it is possible.
 https://dxr.mozilla.org/mozilla-central/source/dom/media/MediaData.cpp#326

Comment 4

[Nicolas Silva [:nical]]

Comment on attachment 8987007 [details] [diff] [review]
patch - Remove IMFYCbCrImage usage in WMFVideoMFTManager::CreateBasicVideoFrame()

Review of attachment 8987007 [details] [diff] [review]:
-----------------------------------------------------------------

Sounds good to me in principle but I don't know that well the implications. Deferring the review to Matt.

Comment 5

[Matt Woodrow (:mattwoodrow)]

The difference between these two is that IMFYCbCrImage just takes a reference to the IMFMediaBuffer in the constructor, instead of making a copy/upload. The upload is done when we request the TextureData.

This moves the upload time from the decoder thread to the image bridge child thread, and (at least when I wrote it) gave us better throughput, since we can start decoding the next frame without waiting. It was noticeable when decoding 4k videos in software.

We only get to use that image type for one path though, since most decoders don't give us a refcounted handle to the image data.

Comment 6

[Sotaro Ikeda [:sotaro]]

Intent of this bug was to recycle ID3D11Texture2D during doing h.264 software decoding. I am going to try another way.

Comment 7

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Recycle TextureClient at IMFYCbCrImage

Comment 8

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Recycle TextureClient at IMFYCbCrImage

Rebased.

Comment 9

[Sotaro Ikeda [:sotaro]]

With attachment 8988045 [details] [diff] [review], IMFYCbCrImage becomes to use D3D11YCbCrRecycleAllocator and DXGIYCbCrTextureAllocationHelper to allocate DXGIYCbCrTextureData.

Comment 10

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=03693a85ee9622dbf7bdbff4a241f6c0bcaa0169&selectedJob=185082394

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b0227fc53bf6
Recycle TextureClient at IMFYCbCrImage r=mattwoodrow

Comment 12

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/b0227fc53bf6