1470393 - squashed favicon in new bookmark dialog

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[Sören Hentzschel]

Attachment: screenshot

In bug 1460248 a preview image and a favicon has been added to the "new bookmark" dialog. But as you can see in the attached image the favicon has the wrong format.

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

This is something we should try to figure out before the 62 release.

Comment 2

[Florens Verschelde :fvsch]

Attachment: squashed-favicon-wide

I have a similar issue, with a different aspect ratio (wide).
Seen on mobile.twitter.com.

It seems to use this image:

https://abs-0.twimg.com/responsive-web/web/ltr/icon-default.882fa4ccf6539401.png

Referenced in the HTML page as:

<link rel="icon" sizes="192x192" href="https://abs-0.twimg.com/responsive-web/web/ltr/icon-default.882fa4ccf6539401.png" />

Comment 3

[Dão Gottwald [:dao]]

Attachment: Bug 1470393 - Implement workaround for squashed favicon in the bookmarking panel.

Review commit: https://reviewboard.mozilla.org/r/253072/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/253072/

Comment 4

[Dão Gottwald [:dao]]

FWIW, I'm calling this a workaround because I'm not sure how this fixes the problem, or why this was broken in the first place...

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 8987796 [details]
Bug 1470393 - Implement workaround for squashed favicon in the bookmarking panel.

https://reviewboard.mozilla.org/r/253072/#review259692

fair enough

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0800ceffc76
Implement workaround for squashed favicon in the bookmarking panel. r=mak

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/d0800ceffc76

Comment 8

[Dão Gottwald [:dao]]

Comment on attachment 8987796 [details]
Bug 1470393 - Implement workaround for squashed favicon in the bookmarking panel.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1460248
[User impact if declined]: see attachment 8987016 [details]
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: don't think so
[List of other uplifts needed for the feature/fix]: /
[Is the change risky?]: no
[Why is the change risky/not risky?]: trivial fix
[String changes made/needed]: /

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8987796 [details]
Bug 1470393 - Implement workaround for squashed favicon in the bookmarking panel.

Let's unsquash that icon for 62 beta 4.

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/f514597a84c4

Comment 11

[Itiel]

Looking good on latest Nightly.

Comment 12

[Damira Akh]

I have verified that the issue is no longer reproducible on the latest Nightly build (63.0a1, 20180711100118) and Beta 62.0b7  on Windows 10 x64, Mac 10.14 and Ubuntu 17.10 x64. 
I marked verified and fixed.