1470395 - Variable SOURCE_VERSION intermittently not defined during Heroku build

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Infrastructure, enhancement, P1)

Description

[Ed Morley [:emorley]]

We make use of the `SOURCE_VERSION` environment variable (inside the Python buildpack `post_compile` step), which is defined by Heroku during the build:
https://devcenter.heroku.com/articles/buildpack-api#bin-compile

However we've now had two separate builds that have failed with:

`bin/post_compile: line 8: SOURCE_VERSION: unbound variable`

(we're using `set -u` thankfully)

The failing builds were:
https://dashboard.heroku.com/apps/treeherder-stage/activity/builds/8800a2a0-9136-4f43-ae79-88fb14e6603d
https://dashboard.heroku.com/apps/treeherder-prototype/activity/builds/fd8f9352-1494-46de-8a47-2e59bc6048ad

I'm presuming this is either an unintended bug with one particular slug-compiler node (hence only occurring intermittently), or else a rolling deploy that's only partially deployed and is going to cause full breakage once complete.

I'll open a Heroku support ticket.

Comment 1

[Ed Morley [:emorley]]

https://help.heroku.com/tickets/599502

Comment 2

[Ed Morley [:emorley]]

Someone from the Heroku build team replied earlier today saying that they know what's causing the failure and have reverted the change on their side.