Closed Bug 1470420 Opened Last year Closed Last year

More Loader cleanup.

Categories

(Core :: CSS Parsing and Computation, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: emilio, Assigned: emilio)

Details

Attachments

(5 files)

No description provided.
Comment on attachment 8987047 [details]
Bug 1470420: Make InsertChildSheet infallible.

https://reviewboard.mozilla.org/r/252294/#review258754
Attachment #8987047 - Flags: review?(xidorn+moz) → review+
Comment on attachment 8987048 [details]
Bug 1470420: Make Stop() infallible.

https://reviewboard.mozilla.org/r/252296/#review258756
Attachment #8987048 - Flags: review?(xidorn+moz) → review+
Comment on attachment 8987050 [details]
Bug 1470420: Change an nsAutoPtr to UniquePtr in the Loader.

https://reviewboard.mozilla.org/r/252300/#review258760
Attachment #8987050 - Flags: review?(xidorn+moz) → review+
Comment on attachment 8987051 [details]
Bug 1470420: Fix some minor style inconsistencies I stumbled upon.

https://reviewboard.mozilla.org/r/252302/#review258762
Attachment #8987051 - Flags: review?(xidorn+moz) → review+
Comment on attachment 8987049 [details]
Bug 1470420: Cleanup ParseSheet.

https://reviewboard.mozilla.org/r/252298/#review258766

::: layout/style/Loader.h:562
(Diff revision 1)
> -                  SheetLoadData* aLoadData,
> -                  bool aAllowAsync,
> +  // Returns whether the parse finished, false otherwise (e.g. if the sheet had
> +  // an @import).

`false otherwise` sounds weird here as you no longer return a bool anymore. Probably rewrite this line to something like
> Returns whether the parse finished. It may not finish e.g. if the sheet had an @import.

::: layout/style/Loader.cpp
(Diff revision 1)
> -  LOG(("css::Loader::ParseSheet"));
> -  MOZ_ASSERT(aLoadData, "Must have load data");

It might still be helpful to have the `LOG` line as well as the assertion on `aLoadData`.
Attachment #8987049 - Flags: review?(xidorn+moz) → review+
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/mozilla-inbound/rev/136247a01cbf
Make InsertChildSheet infallible. r=xidorn
https://hg.mozilla.org/integration/mozilla-inbound/rev/f1f7160233b1
Make Stop() infallible. r=xidorn
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f3dd9d99d78
Cleanup ParseSheet. r=xidorn
https://hg.mozilla.org/integration/mozilla-inbound/rev/ad3352de6bca
Change an nsAutoPtr to UniquePtr in the Loader. r=xidorn
https://hg.mozilla.org/integration/mozilla-inbound/rev/342a2a4aa8a8
Fix some minor style inconsistencies I stumbled upon. r=xidorn
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3ca934cfed6a
followup: Try to fix the build in some compilers. r=me CLOSED TREE
You need to log in before you can comment on or make changes to this bug.