1470420 - More Loader cleanup.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1470420: Make InsertChildSheet infallible.

Review commit: https://reviewboard.mozilla.org/r/252294/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/252294/

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1470420: Make Stop() infallible.

Review commit: https://reviewboard.mozilla.org/r/252296/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/252296/

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1470420: Cleanup ParseSheet.

Review commit: https://reviewboard.mozilla.org/r/252298/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/252298/

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1470420: Change an nsAutoPtr to UniquePtr in the Loader.

Review commit: https://reviewboard.mozilla.org/r/252300/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/252300/

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1470420: Fix some minor style inconsistencies I stumbled upon.

Review commit: https://reviewboard.mozilla.org/r/252302/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/252302/

Comment 6

[Xidorn Quan [:xidorn] UTC+11]

Comment on attachment 8987047 [details]
Bug 1470420: Make InsertChildSheet infallible.

https://reviewboard.mozilla.org/r/252294/#review258754

Comment 7

[Xidorn Quan [:xidorn] UTC+11]

Comment on attachment 8987048 [details]
Bug 1470420: Make Stop() infallible.

https://reviewboard.mozilla.org/r/252296/#review258756

Comment 8

[Xidorn Quan [:xidorn] UTC+11]

Comment on attachment 8987050 [details]
Bug 1470420: Change an nsAutoPtr to UniquePtr in the Loader.

https://reviewboard.mozilla.org/r/252300/#review258760

Comment 9

[Xidorn Quan [:xidorn] UTC+11]

Comment on attachment 8987051 [details]
Bug 1470420: Fix some minor style inconsistencies I stumbled upon.

https://reviewboard.mozilla.org/r/252302/#review258762

Comment 10

[Xidorn Quan [:xidorn] UTC+11]

Comment on attachment 8987049 [details]
Bug 1470420: Cleanup ParseSheet.

https://reviewboard.mozilla.org/r/252298/#review258766

::: layout/style/Loader.h:562
(Diff revision 1)
> -                  SheetLoadData* aLoadData,
> -                  bool aAllowAsync,
> +  // Returns whether the parse finished, false otherwise (e.g. if the sheet had
> +  // an @import).

`false otherwise` sounds weird here as you no longer return a bool anymore. Probably rewrite this line to something like
> Returns whether the parse finished. It may not finish e.g. if the sheet had an @import.

::: layout/style/Loader.cpp
(Diff revision 1)
> -  LOG(("css::Loader::ParseSheet"));
> -  MOZ_ASSERT(aLoadData, "Must have load data");

It might still be helpful to have the `LOG` line as well as the assertion on `aLoadData`.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/136247a01cbf
Make InsertChildSheet infallible. r=xidorn
https://hg.mozilla.org/integration/mozilla-inbound/rev/f1f7160233b1
Make Stop() infallible. r=xidorn
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f3dd9d99d78
Cleanup ParseSheet. r=xidorn
https://hg.mozilla.org/integration/mozilla-inbound/rev/ad3352de6bca
Change an nsAutoPtr to UniquePtr in the Loader. r=xidorn
https://hg.mozilla.org/integration/mozilla-inbound/rev/342a2a4aa8a8
Fix some minor style inconsistencies I stumbled upon. r=xidorn

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3ca934cfed6a
followup: Try to fix the build in some compilers. r=me CLOSED TREE

Comment 13

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/136247a01cbf
https://hg.mozilla.org/mozilla-central/rev/f1f7160233b1
https://hg.mozilla.org/mozilla-central/rev/0f3dd9d99d78
https://hg.mozilla.org/mozilla-central/rev/ad3352de6bca
https://hg.mozilla.org/mozilla-central/rev/342a2a4aa8a8
https://hg.mozilla.org/mozilla-central/rev/3ca934cfed6a