Output the process type (not just PID) in MOZ_LOG

RESOLVED FIXED in Firefox 63

Status

()

enhancement
RESOLVED FIXED
Last year
Last year

People

(Reporter: tjr, Assigned: tjr)

Tracking

unspecified
mozilla63
Points:
---

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

We do this for NS_WARNING and such, but not MOZ_LOG.  It seems like it would be helpful.  (It would have saved me a bit of time from getting confused.)
Posted patch outputpid.patch (obsolete) — Splinter Review
Attachment #8987129 - Flags: review?(nfroyd)
Attachment #8987129 - Attachment is patch: true
Comment on attachment 8987129 [details] [diff] [review]
outputpid.patch

Review of attachment 8987129 [details] [diff] [review]:
-----------------------------------------------------------------

...and the logging lines continue to expand...

Splinter is yelling at me about a WINDOWS PATCH; does that automatically resolve itself when you push, or do you have to fix up the patch manually?
Attachment #8987129 - Flags: review?(nfroyd) → review+
Comment on attachment 8987129 [details] [diff] [review]
outputpid.patch

Review of attachment 8987129 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/base/Logging.cpp
@@ +462,5 @@
>      if (!mAddTimestamp) {
>        if (!mIsRaw) {
>          fprintf_stderr(out,
> +                      "[%s %ld: %s]: %s/%s %s%s",
> +                      nsDebugImpl::GetMultiprocessMode(), pid, currentThreadName, ToLogStr(aLevel),

Presumably you want this in the timestamped version as well.
Patch should now be in unix format, and fixed up the timestamped version also.
Attachment #8987129 - Attachment is obsolete: true
Attachment #8987634 - Flags: review+
Keywords: checkin-needed
Pushed by nerli@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d0bc7c47b115
Output the process name in MOZ_LOG r=froydnj
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/d0bc7c47b115
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.