Closed Bug 1470525 Opened Last year Closed Last year

Support for not displaying synced tabs in awesomebar results

Categories

(Firefox :: Sync, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 62
Tracking Status
firefox62 --- fixed

People

(Reporter: Felipe, Assigned: Felipe)

Details

Attachments

(1 file)

I want to keep using the Synced Tabs feature through the Sidebar panel, but they confuse me in the awesomebar results as I'm a tab hoarder..

This adds an invisible pref to allow the synced tabs to not be added to the awesomebar results..

Let me know if I should add this pref to firefox.js, and if the name for this pref is OK
Comment on attachment 8987156 [details]
Bug 1470525 - Support for not displaying synced tabs in awesomebar results.

https://reviewboard.mozilla.org/r/252396/#review258924

Thanks! The pref name looks good, and I don't think it's worth adding to `firefox.js`.

::: toolkit/components/places/PlacesRemoteTabsAutocompleteProvider.jsm:112
(Diff revision 1)
>  Services.obs.addObserver(observe, "weave:service:start-over");
>  
> -// Observe the pref for showing remote icons and prime our bool that reflects its value.
> +// Observe the prefs for showing remote icons and tabs and prime
> +// our bools that reflect their values.
>  Services.prefs.addObserver(PREF_SHOW_REMOTE_ICONS, observe);
> +Services.prefs.addObserver(PREF_SHOW_REMOTE_TABS, observe);

Nit: If you want, I think you could add just one observer for the `services.sync.syncedTabs.` branch, but this is fine, too!
Attachment #8987156 - Flags: review?(kit) → review+
Comment on attachment 8987156 [details]
Bug 1470525 - Support for not displaying synced tabs in awesomebar results.

https://reviewboard.mozilla.org/r/252396/#review258924

> Nit: If you want, I think you could add just one observer for the `services.sync.syncedTabs.` branch, but this is fine, too!

in the interest of just hitting autoland, I'll keep it as is :P
Pushed by felipc@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/3282f024ea83
Support for not displaying synced tabs in awesomebar results. r=lina
https://hg.mozilla.org/mozilla-central/rev/3282f024ea83
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
You need to log in before you can comment on or make changes to this bug.