Update Makefile.in attempting to add a dependency on a GENERATED_FILES target

RESOLVED FIXED in Firefox 62

Status

enhancement
RESOLVED FIXED
Last year
Last year

People

(Reporter: chmanchester, Assigned: chmanchester)

Tracking

Trunk
mozilla62
Dependency tree / graph

Firefox Tracking Flags

(firefox62 fixed)

Details

Attachments

(1 attachment)

Bug 1454912 changed the actual target for all GENERATED_FILES. We have a hack in the root Makefile.in to ensure we re-generate the buildid in certain circumstances, which references the actual file rather the stub target, so it no longer works.
Attachment #8987181 - Flags: review?(core-build-config-reviews) → review?(nfroyd)

Comment 2

Last year
mozreview-review
Comment on attachment 8987181 [details]
Bug 1470552 - Update Makefile.in to refer to stub file target for buildid.h and source-repo.h generated in backend.mk

https://reviewboard.mozilla.org/r/252424/#review258934

Doh!
Attachment #8987181 - Flags: review?(nfroyd) → review+

Comment 3

Last year
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/567df8598cdb
Update Makefile.in to refer to stub file target for buildid.h and source-repo.h generated in backend.mk r=froydnj

Comment 4

Last year
Backout by aciure@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bf56c04574dd
Backed out 1 changesets for build bustages mozbuild/test/backend/test_build.py CLOSED TREE
This test is pretty brittle. Fix incoming.
Flags: needinfo?(cmanchester)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 9

Last year
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1dbc843c1429
Update Makefile.in to refer to stub file target for buildid.h and source-repo.h generated in backend.mk r=froydnj
https://hg.mozilla.org/mozilla-central/rev/1dbc843c1429
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.