Closed Bug 1470587 Opened 6 years ago Closed 6 years ago

Intermittent browser/modules/test/browser/browser_BrowserErrorReporter_nightly.js | browser.errors.collected_count is incremented when an error is collected. - Got 4, expected 3

Categories

(Firefox :: General, defect, P5)

Product:
Firefox
Component:
General
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: osmose)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Bug 1470587: Uninitialize reporter created during test.
46 bytes, text/x-phabricator-request
mossop
: review+
Details | Review 
Filed by: aciure [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=184435391&repo=autoland

https://queue.taskcluster.net/v1/task/KX8ik7rDQeGlRoU18yuNFA/runs/0/artifacts/public/logs/live_backing.log

[task 2018-06-22T21:14:55.361Z] 21:14:55     INFO - TEST-PASS | browser/modules/test/browser/browser_BrowserErrorReporter_nightly.js | Errors from extensions have an isExtensionError=true tag. - 
[task 2018-06-22T21:14:55.362Z] 21:14:55     INFO - TEST-PASS | browser/modules/test/browser/browser_BrowserErrorReporter_nightly.js | Normal errors have an isExtensionError=false tag. - 
[task 2018-06-22T21:14:55.363Z] 21:14:55     INFO - Leaving test bound testExtensionTag
[task 2018-06-22T21:14:55.363Z] 21:14:55     INFO - Entering test bound testScalars
[task 2018-06-22T21:14:55.364Z] 21:14:55     INFO - Buffered messages finished
[task 2018-06-22T21:14:55.365Z] 21:14:55     INFO - TEST-UNEXPECTED-FAIL | browser/modules/test/browser/browser_BrowserErrorReporter_nightly.js | browser.errors.collected_count is incremented when an error is collected. - Got 4, expected 3
[task 2018-06-22T21:14:55.366Z] 21:14:55     INFO - Stack trace:
[task 2018-06-22T21:14:55.366Z] 21:14:55     INFO - chrome://mochikit/content/browser-test.js:test_is:1300
[task 2018-06-22T21:14:55.367Z] 21:14:55     INFO - chrome://mochitests/content/browser/browser/modules/test/browser/browser_BrowserErrorReporter_nightly.js:testScalars:438
[task 2018-06-22T21:14:55.367Z] 21:14:55     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1098
[task 2018-06-22T21:14:55.367Z] 21:14:55     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1089
[task 2018-06-22T21:14:55.368Z] 21:14:55     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:986
[task 2018-06-22T21:14:55.368Z] 21:14:55     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795
[task 2018-06-22T21:14:55.369Z] 21:14:55     INFO - TEST-PASS | browser/modules/test/browser/browser_BrowserErrorReporter_nightly.js | browser.errors.sample_rate contains the last sample rate used. - 
[task 2018-06-22T21:14:55.370Z] 21:14:55     INFO - Not taking screenshot here: see the one that was previously logged
[task 2018-06-22T21:14:55.371Z] 21:14:55     INFO - TEST-UNEXPECTED-FAIL | browser/modules/test/browser/browser_BrowserErrorReporter_nightly.js | browser.errors.reported_success_count is incremented when an error is reported. - Got 2, expected 1
[task 2018-06-22T21:14:55.372Z] 21:14:55     INFO - Stack trace:
[task 2018-06-22T21:14:55.372Z] 21:14:55     INFO - chrome://mochikit/content/browser-test.js:test_is:1300
[task 2018-06-22T21:14:55.372Z] 21:14:55     INFO - chrome://mochitests/content/browser/browser/modules/test/browser/browser_BrowserErrorReporter_nightly.js:testScalars:448
[task 2018-06-22T21:14:55.373Z] 21:14:55     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1098
[task 2018-06-22T21:14:55.373Z] 21:14:55     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1089
[task 2018-06-22T21:14:55.374Z] 21:14:55     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:986
[task 2018-06-22T21:14:55.374Z] 21:14:55     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795
[task 2018-06-22T21:14:55.375Z] 21:14:55     INFO - TEST-PASS | browser/modules/test/browser/browser_BrowserErrorReporter_nightly.js | browser.errors.reported_failure_count is incremented when an error fails to be reported. - 
[task 2018-06-22T21:14:55.376Z] 21:14:55     INFO - Leaving test bound testScalars
[task 2018-06-22T21:14:55.377Z] 21:14:55     INFO - GECKO(2585) | MEMORY STAT | vsize 2167MB | residentFast 355MB | heapAllocated 149MB
[task 2018-06-22T21:14:55.378Z] 21:14:55     INFO - TEST-OK | browser/modules/test/browser/browser_BrowserErrorReporter_nightly.js | took 1326ms
[task 2018-06-22T21:14:55.379Z] 21:14:55     INFO - checking window state
At some point, the matching call to reporter.uninit got removed from this test.
The result is that the reporter still exists and is still collecting errors
during the rest of the tasks in the file. In most tasks, this isn't an issue
since we use reporter.handleMessage to test message handling at a per-reporter
level.

But the telemetry measures are shared between multiple reporters, thus they are
susceptible to interference from other running reporter instances.

The error that is being logged when this test fails is from the test add-on
created in testAddonIDMangle. My best guess is that the error logged by the
add-on is being processed during an idle moment in another task, since we
schedule processing to be delayed until the browser is idle. It seems this
scheduling is pretty consistent on certain Linux platforms.
Assignee: nobody → mkelly
Comment on attachment 8987916 [details]
Bug 1470587: Uninitialize reporter created during test.

Dave Townsend [:mossop] has approved the revision.

https://phabricator.services.mozilla.com/D1836
Attachment #8987916 - Flags: review+
Pushed by mkelly@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d26f85971b0a
Uninitialize reporter created during test. r=mossop
https://hg.mozilla.org/mozilla-central/rev/d26f85971b0a
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: