Closed Bug 14706 Opened 25 years ago Closed 25 years ago

function returns value of incorrect sign

Categories

(Core :: XPCOM, defect, P3)

Product:
Core
Component:
XPCOM
Type:
defect

Tracking

()

Status:
RESOLVED INVALID

People

(Reporter: colin, Assigned: scc-obsolete)

Details

In xpcom/ds/nsPageMgr.cpp is function nsPageMgr::Init.
The type of this function is nsresult which is UNsigned.
Within the routine is:

    if (mMonitor == NULL)
        return PR_FAILURE;

PR_FAILURE is an enum with a value of -1.

A signed return within an unsigned function causes my
compiler to complain.

Colin.
Assignee: dp → dougt
Target Milestone: M12
colin, is this a warning or an error?
It's a warning.
QA Contact: beppe → don
assigning DON as QA contact -- I don't know who else to assign this to Don.
Assignee: dougt → scc
scott, can you quickly fix this.
Status: NEW → ASSIGNED
...I guess so.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → INVALID
uhhh, I don't have any such file "nsPageMgr.cpp", and I can't find the routine |

nsPageMgr::Init| using lxr... is this bug invalid?  colin?
I think this code was part of the necko memory management routines. Anyway,
its clearly been removed since I reported it, so just close the bug report.
QA Contact: don → kandrot
You need to log in before you can comment on or make changes to this bug.