1470600 - Perfherder comparisons are very slow

Status: RESOLVED FIXED

(Tree Management :: Perfherder, enhancement)

Description

[Eric Rahm [:erahm]]

+++ This bug was initially created as a clone of Bug #1470599 +++

Loads appear to be taking minutes at least on try. For example try loading:

https://treeherder.mozilla.org/perf.html#/compare?originalProject=mozilla-central&newProject=try&newRevision=2c507100e0bb328df03b7a2633ba0ae424a3fd56&framework=4&selectedTimeRange=172800

Comment 1

[William Lachance (:wlach)]

Looking at the console, something weird is happening here. It's finishing loading at least an initial set of results very quickly, but nothing is being displayed. I suspect we're missing a digest cycle somewhere or similar.

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3714

Comment 3

[William Lachance (:wlach)]

Comment on attachment 8987651 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3714

This code badly needs to be rewritten, as it's totally confusing. But this fixes the case that :erahm found.

https://stackoverflow.com/a/28797230

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/5326b971fe8dc3d0f11f3129a93843312a83daf8
Bug 1470600 - Fix non-displaying/slow-to-display perfherder compare view (#3714)

Call digest explicitly when displaying results, so we don't have to worry
when promises get resolved.

Comment 5

[Ed Morley [:emorley]]

This has been deployed to production.

Comment 6

[William Lachance (:wlach)]

(In reply to Ed Morley [:emorley] from comment #5)
> This has been deployed to production.

Thanks Ed!