147061 - Changing Css style=" display: none;" to style=" display: default;" is SLOW

Status: RESOLVED WORKSFORME

(SeaMonkey :: General, defect)

Description

[Juan Pablo Alcaraz]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.9) Gecko/20020311
BuildID:    

When I change de table style=" display: none;" to default value or viceversa the
operation is very slow

Reproducible: Always
Steps to Reproduce:
1. go to http://www.laotraesquina.com.ar
2. CLick in "Ampliar Mensajes" link


Actual Results:  The messages are showed Slowly

Expected Results:  Idem but faster

Speed is compared to IE 5

Comment 1

[Alfonso Martinez]

For me the speed is correct, almost no delay at all. win98, Mozilla 1.0RC3
You should try to download the latest version of Mozilla (RC3) and try again.

Comment 2

[Christopher Aillon (sabbatical, not receiving bugmail)]

I'm pretty sure Boris fixed a few speed issues between 0.9.9 and RC1 with
setting style.foo stuff.  I'll try and find the exact bug later on where he
fixed this, but upgrading to an RC3 version or trunk should fix this issue for you.

Comment 3

[Boris Zbarsky [:bzbarsky]]

The fix I did was to make changing things that do not need a reframe to be 
faster.  Changes in |display| need a reframe.  Removing the DUPEME for now...

I have no Mozilla build at the moment, so there is no way for me to test this.  
Some data on the exact speed here with 0.9.9, RC3, current trunk, etc. would be 
nice.  If someone would be willing to take the page and add some timing stuff 
to the JS that would rock.

Comment 4

[Juan Pablo Alcaraz]

In 0.9.9 the time is 6 seconds vs < 0.3 seconds of IE 5

Comment 5

[Boris Zbarsky [:bzbarsky]]

OK.  When I do it with a current trunk build, it takes about half the time it
takes in IE 5.0 (both times well under half a second).

I suspect that one of the man performance fixes that have landed since 0.9.9
fixed this.

On a separate note, setting the display of a <table> to "inline" is not that
great an idea -- it does not do what you think it does....

Comment 6

[Juan Pablo Alcaraz]

I test the problem with mozilla 0.9.9 and it's slow too (in a Athlon box!)

"On a separate note, setting the display of a <table> to "inline" is not that
great an idea -- it does not do what you think it does...."

Thanks for the observation. I'll fix.  :-)

Comment 7

[Boris Zbarsky [:bzbarsky]]

Yes... please test a _recent_ (not 0.9.9, not RC3, but trunk) build.

Comment 8

[Jonathan Gardner]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.1a) Gecko/20020610

Instantaneous. I have an Athlon 1.00 GHz, almost a gig of RAM.

Comment 9

[Juan Pablo Alcaraz]

In 1.0 is fast. For me it's fixed.

Comment 10

[Matthias Versen [:Matti]]

thx !

-> wfm