1470633 - Show chosen "Preferred locales" in the same order they are added

Status: RESOLVED FIXED

(Webtools Graveyard :: Pontoon, defect, P3)

Description

[Jakob Kappel]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:62.0) Gecko/20100101 Firefox/62.0
Build ID: 20180617220505

Steps to reproduce:

My list of preferred locales to get suggestions from had magically disappeared, so I chose a new set of locales on https://pontoon.mozilla.org/settings/


Actual results:

The locales were added to the right side list ("Chosen") in the reverse order of the order I added the locales in. 


Expected results:

The first locale I choose should be number one on the final list, the second locale number two and so on. 

----

MOTIVATION:
I assume that most localizers know exactly which locale(s) they want to see suggestions from first, and that they are more uncertain about locales further down the list. 

You can rearrange the order of locales after adding them, but this option isn't easily discoverable. And it's pretty fiddly if you have more locales than the list is able to show without scrolling.

Comment 1

[Matjaz Horvat [:mathjazz]]

That's a good point. Taking.

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/981

Comment 3

[Matjaz Horvat [:mathjazz]]

It's a simple patch - we just need to append instead of prepend locales and scroll to the bottom of the list.

Jakob, could you confirm it works OK on stage?
https://mozilla-pontoon-staging.herokuapp.com/settings/

Comment 4

[Jakob Kappel]

Yes, that's perfect. Thanks, Matjaž!

But it does have the strange side effect, that "Remove all" moves locales from "Chosen" to the bottom of "Available" instead of returning them to their proper place in the alphabetized list. 

Hmm. On production "Remove all" moves the locales to the top.

Comment 5

[Jakob Kappel]

Second thought: Moving chosen locales to the top of the list with "Remove all" actually might be a feature, not a bug. 

If the user isn't aware that s/he can drag and drop the locales in "Chosen", moving locales to the top probably makes it easier to correct mistakes in the original order of locales.

Comment 6

[Matjaz Horvat [:mathjazz]]

Yeah, that's a feature - it allows you to see locales that you moved one way or the other. It's also consistent with what happens when you move locales one by one.

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/pontoon

https://github.com/mozilla/pontoon/commit/fe0a6414eb92c32ba94e47501ec0529faaa789ba
Fix bug 1470633: Add locales to the bottom of the list (#981)

In multiple locale selector, we used to prepend locales to the list
when they were selected. Now we append them.

Affected pages are Settings, Project Admin and Project Notificaions.

The benefit is especially useful on the Setting page, where preferred
locales are selected for which the order is important. The one selected
first will now also be the one on top of the list in the Locales tab in
translate view.