Open Bug 1470690 Opened 6 years ago Updated 2 years ago

All Tabs list flickers before showing the set of tabs that are shown on the tab strip


(Firefox :: Tabbed Browser, defect, P3)




Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox61 --- unaffected
firefox62 --- wontfix
firefox63 --- wontfix
firefox64 --- wontfix
firefox65 --- wontfix
firefox66 --- wontfix
firefox67 --- wontfix
firefox68 --- wontfix
firefox69 --- wontfix
firefox70 --- fix-optional


(Reporter: itiel_yn8, Unassigned, NeedInfo)



(Keywords: regression)


(1 file)

Attached image Screencast.gif
Using Windows 10 x86.

1. Using the latest Nightly, open many new tabs so the tab strip would contain about x3 its tab capacity
2. Scroll to the middle of the tab strip and select one of the tabs. Load any webpage on this tab
3. Click the All Tabs button

The list fickers before showing the set of tabs that are shown on the tab strip, and for a split second shows the first tabs on the tab strip

When clicking the All Tabs button, the popup should immediately show the displayed set of tabs on the tab strip.

This was okay in the previous implementation of the All Tabs list.

See attached.
Keywords: regression
Priority: -- → P2
Dao, this bug is an unassigned P2, should we re-prioritize this bug? Thanks
Flags: needinfo?(dao+bmo)
Mark, can you look into this?
Flags: needinfo?(dao+bmo) → needinfo?(mstriemer)
Too late for a fix in 63. We can still take a fix in 65 or potentially in 64.
I tried digging into this again, wasn't able to sort it all out.

The best bet seems to be to move the scroll to ViewShowing from ViewShown. This needs to be done in a `requestAnimationFrame()` as far as I can tell, I'm guessing due to when ViewShowing is called. This sort of works, but once ViewShown is called the panel has shrunk by 15px. Making some of the optional UI hidden in the XUL seems to increase that to 74px. I guess something is changing here, but I wasn't able to track it down. I can't see the panel visibly changing size during its transition to showing, so I'm not sure what's up with that.

I'll look into this more at a later date, but don't have much more time to spend right now.

Dao, this bug has been marked as a P2 since 61 (P2 = "Fix in the next release or iteration") can this be either assigned or moved to the backlog (P3) if there are no plans to fix it in 67? Thanks!

Flags: needinfo?(dao+bmo)
Flags: needinfo?(dao+bmo)
Priority: P2 → P3

Happy to take a patch here of course, but given that this has gotten some developer attention, and then it's had the priority set to P3 which is basically backlog, I'm marking this fix-optional again to remove it from weekly triage.

Severity: normal → S3

The severity field for this bug is relatively low, S3. However, the bug has 78 votes.
:dao, could you consider increasing the bug severity?

For more information, please visit auto_nag documentation.

Flags: needinfo?(dao+bmo)

The last needinfo from me was triggered in error by recent activity on the bug. I'm clearing the needinfo since this is a very old bug and I don't know if it's still relevant.

Flags: needinfo?(dao+bmo)
You need to log in before you can comment on or make changes to this bug.