Closed Bug 1470695 Opened 7 years ago Closed 6 years ago

Implement overflow-block and overflow-inline properties

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: sebo, Assigned: violet.bugreport)

References

(Blocks 1 open bug,
URL
)

Details

(Keywords: dev-doc-complete)

Attachments

(2 files)

Bug 1470695 - Implement overflow-block and overflow-inline properties
47 bytes, text/x-phabricator-request
Details | Review
MDN: Browser compatibility table update
52 bytes, text/x-github-pull-request
Details | Review
The CSS Overflow Module defines two logical properties 'overflow-block' and 'overflow-inline' corresponding to 'overflow-x' and 'overflow-y' depending on the writing mode. Therefore those should be implemented. Sebastian
Priority: -- → P3
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE

Ah.. This one is for "overflow-block" property, not the "overflow-block" media query. Sorry for the spam.
FWIW, no one has supported the property yet, and Firefox is the only one supporting the media query.

Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---

Chrome canary supports overflow-block and overflow-inline, fwiw.

(In reply to Emilio Cobos Álvarez (:emilio) from comment #3)

Chrome canary supports overflow-block and overflow-inline, fwiw.

Are we going to support it as well? I'll take this bug if that's the case.
(I think we just need to modify some mako files in Rust side, which should be straightforward)

Flags: needinfo?(emilio)

Yeah, I don't see why not, should be straight-forward.

Flags: needinfo?(emilio)
Assignee: nobody → violet.bugreport
Status: REOPENED → ASSIGNED

writing-mode on html is propagated from <body>, I haven't tried D34738, does it work as expected? It's worth adding a test case if there isn't such cases.

(In reply to Hiroyuki Ikezoe (:hiro) from comment #7)

writing-mode on html is propagated from <body>, I haven't tried D34738, does it work as expected?

I don't see how the propagation rule is relevant here. See https://drafts.csswg.org/css-writing-modes-3/#principal-flow, emphasis mine:

As a special case for handling HTML documents, if the root element has a body child element [HTML], the principal writing mode is instead taken from the values of writing-mode and direction on the first such child element instead of taken from the root element. Note that this does not affect the values of writing-mode or direction on the root element itself.

https://drafts.csswg.org/css-overflow-3/#logical

These properties correspond to the overflow-x and overflow-y properties. The mapping depends on the element’s writing-mode.

All existing logical properties like block-size behave the same way in every browser AFAIK.

Yeah, I've noticed the spec, and I think you are right, but it's not clear to me whether Firefox does work as expected with/without D34738. (And I suspect Firefox doesn't work in some of cases, but yes, it's might be unrelated to this bug though)

(Just FYI, the propagation you mentioned doesn't work on Firefox, relevant WPT tests are failure)

Pushed by violet.bugreport@gmail.com: https://hg.mozilla.org/integration/autoland/rev/34fe5158610a Implement overflow-block and overflow-inline properties r=emilio

https://hg.mozilla.org/mozilla-central/rev/34fe5158610a

Status: ASSIGNED → RESOLVED
Closed: 6 years ago → 6 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: