Closed
Bug 1470735
Opened 6 years ago
Closed 6 years ago
Import just forIn from lodash for perfherder compare
Categories
(Tree Management :: Treeherder: Frontend, defect, P3)
Tree Management
Treeherder: Frontend
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: vykuntamsrinivas, Assigned: SirR4T)
References
Details
Attachments
(1 file)
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.87 Safari/537.36 Steps to reproduce: Search for _.forIn in treeherder UI Actual results: we are using _forIn() Expected results: We are going to use for(i in Object) from native ES6
Updated•6 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P3
Updated•6 years ago
|
Assignee: nobody → vykuntamsrinivas
Status: NEW → ASSIGNED
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
needs review.
Updated•6 years ago
|
Assignee: vykuntamsrinivas → sarat.addepalli
Updated•6 years ago
|
Attachment #8996661 -
Flags: review?(wlachance)
Assignee | ||
Comment 3•6 years ago
|
||
Hmm. I think the opposite of https://bugzilla.mozilla.org/show_bug.cgi?id=1468160#c6 has happened here: This bugzilla bug has the review flags updated, but the GitHub PR doesn't have a reviewer tagged. 🤨
Comment 4•6 years ago
|
||
Comment on attachment 8996661 [details] [review] Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3861 left feedback in pr
Attachment #8996661 -
Flags: review?(wlachance)
Comment 5•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/4b4e51cb544ca11f625c61906ecc4856f768b107 Bug 1470735 - Import just forIn from lodash for perfherder compare (#3861)
Updated•6 years ago
|
Summary: Convert lodash .forIn() to native ES6 → Import just forIn from lodash for perfherder compare
Comment 6•6 years ago
|
||
We're now using a more specific import, rather than removing the usage of forIn wholesale. Thanks to Sir4t for the patch
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•