1470735 - Import just forIn from lodash for perfherder compare

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, defect, P3)

Description

[srinivas]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.87 Safari/537.36

Steps to reproduce:

Search for _.forIn in treeherder UI


Actual results:

we are using _forIn()


Expected results:

We are going to use for(i in Object) from native ES6

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3861

Comment 2

[Sarat Addepalli [:SirR4T]]

needs review.

Comment 3

[Sarat Addepalli [:SirR4T]]

Hmm. I think the opposite of https://bugzilla.mozilla.org/show_bug.cgi?id=1468160#c6 has happened here:
This bugzilla bug has the review flags updated, but the GitHub PR doesn't have a reviewer tagged. 🤨

Comment 4

[William Lachance (:wlach)]

Comment on attachment 8996661 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3861

left feedback in pr

Comment 5

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/4b4e51cb544ca11f625c61906ecc4856f768b107
Bug 1470735 - Import just forIn from lodash for perfherder compare (#3861)

Comment 6

[William Lachance (:wlach)]

We're now using a more specific import, rather than removing the usage of forIn wholesale. Thanks to Sir4t for the patch