14708 - Fix small compiler warning in nsScriptableDateFormat.cpp

Status: VERIFIED FIXED

(Core :: Internationalization, defect, P3)

Description

[Colin Blake]

mktime returns (time_t)-1 in the event of an error, so the -1 in the
attached needs casting to time_t.

Index: nsScriptableDateFormat.cpp
===================================================================
RCS file: /cvsroot/mozilla/intl/locale/src/nsScriptableDateFormat.cpp,v
retrieving revision 1.6
diff -u -r1.6 nsScriptableDateFormat.cpp
--- nsScriptableDateFormat.cpp  1999/09/08 20:08:15     1.6
+++ nsScriptableDateFormat.cpp  1999/09/23 14:00:57
@@ -115,7 +115,7 @@
         tmTime.tm_yday = tmTime.tm_wday = 0;
         tmTime.tm_isdst = -1;
         timetTime = mktime(&tmTime);
-        if (-1 != timetTime) {
+        if ((time_t)-1 != timetTime) {
           rv = aDateTimeFormat->FormatTime(aLocale, dateFormatSelector,
timeFormatSelector,
                                            timetTime, mStringOut);
           if (NS_SUCCEEDED(rv)) {

Comment 1

[Colin Blake]

I can check this fix in (assuming I get approval from Chris H) if you
want to give me the go-ahead.

Comment 2

[Frank Tang]

nhotta, please review this . This is your code.

Comment 3

[nhottanscp]

The patch looks fine to me.

Comment 4

[Colin Blake]

I just checked this in (rev 1.7) with Chris' permission.

Comment 5

[Teruko Kobayashi]

Changed QA contact to [e-mail].
Hotta san, please just mark this bug to verified.

Comment 6

[nhottanscp]

Verified, I checked the rev 1.7.